Fix a lot of test related typing issues

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.zuban]
 # Exclude our copies of external stubs
-exclude = "^jedi/third_party"
+exclude = "^jedi/third_party|^test/(completion|refactor|static_analysis|examples)/"
 
 show_error_codes = true
 enable_error_code = "ignore-without-code"

scripts/memory_check.py

@@ -13,7 +13,7 @@ Note: This requires the psutil library, available on PyPI.
 import time
 import sys
 import os
-import psutil
+import psutil  # type: ignore[import-untyped]
 sys.path.insert(0, os.path.abspath(os.path.dirname(__file__) + '/..'))
 import jedi
 

scripts/profile_output.py

@@ -56,7 +56,7 @@ def main(args):
         run(code, i, infer=infer)
 
     if args['--precision']:
-        pstats.f8 = f8
+        pstats.f8 = f8  # type: ignore[attr-defined]  # TODO this does not seem to exist?!
 
     jedi.set_debug_function(notices=args['--debug'])
     if args['--omit']:

scripts/wx_check.py

@@ -17,11 +17,11 @@ import sys
 try:
     import urllib.request as urllib2
 except ImportError:
-    import urllib2
+    import urllib2  # type: ignore[import-not-found, no-redef]
 import gc
 from os.path import abspath, dirname
 
-import objgraph
+import objgraph  # type: ignore[import-untyped]
 
 sys.path.insert(0, dirname(dirname(abspath(__file__))))
 import jedi

setup.py

@@ -37,7 +37,7 @@ setup(name='jedi',
       packages=find_packages(exclude=['test', 'test.*']),
       python_requires='>=3.8',
       # Python 3.13 grammars are added to parso in 0.8.4
-      install_requires=['parso>=0.8.5,<0.9.0'],
+      install_requires=['parso>=0.8.6,<0.9.0'],
       extras_require={
           'testing': [
               'pytest<9.0.0',

sith.py

@@ -35,7 +35,6 @@ Usage:
 Options:
   -h --help             Show this screen.
   --record=<file>       Exceptions are recorded in here [default: record.json].
-  -f, --fs-cache        By default, file system cache is off for reproducibility.
   -n, --maxtries=<nr>   Maximum of random tries [default: 100]
   -d, --debug           Jedi print debugging when an error is raised.
   -s                    Shows the path/line numbers of every completion before it starts.
@@ -187,7 +186,6 @@ def main(arguments):
                'pudb' if arguments['--pudb'] else None
     record = arguments['--record']
 
-    jedi.settings.use_filesystem_cache = arguments['--fs-cache']
     if arguments['--debug']:
         jedi.set_debug_function()
 

test/conftest.py

@@ -14,7 +14,7 @@ from jedi.api.interpreter import MixedModuleContext
 # For interpreter tests sometimes the path of this directory is in the sys
 # path, which we definitely don't want. So just remove it globally.
 try:
-    sys.path.remove(helpers.test_dir)
+    sys.path.remove(str(helpers.test_dir))
 except ValueError:
     pass
 

test/run.py

@@ -168,6 +168,8 @@ class BaseTestCase(object):
 
 
 class IntegrationTestCase(BaseTestCase):
+    source: str  # Defined as a side effect
+
     def __init__(self, test_type, correct, line_nr, column, start, line,
                  path=None, skip_version_info=None):
         super().__init__(skip_version_info)

test/test_api/test_completion.py

@@ -3,6 +3,7 @@ import os
 from textwrap import dedent
 from itertools import count
 from pathlib import Path
+from typing import Any
 
 import pytest
 
@@ -301,7 +302,7 @@ def test_file_path_should_have_completions(Script):
     assert Script('r"').complete()  # See GH #1503
 
 
-_dict_keys_completion_tests = [
+_dict_keys_completion_tests: "list[tuple[str, int | None, list[str | Any]]]" = [
     ('ints[', 5, ['1', '50', Ellipsis]),
     ('ints[]', 5, ['1', '50', Ellipsis]),
     ('ints[1]', 5, ['1', '50', Ellipsis]),

test/test_api/test_environment.py

@@ -32,7 +32,7 @@ def test_versions(version):
     try:
         env = get_system_environment(version)
     except InvalidPythonEnvironment:
-        if int(version.replace('.', '')) == str(sys.version_info[0]) + str(sys.version_info[1]):
+        if version.replace('.', '') == str(sys.version_info[0]) + str(sys.version_info[1]):
             # At least the current version has to work
             raise
         pytest.skip()

test/test_api/test_full_name.py

@@ -15,6 +15,7 @@ There are three kinds of test:
 
 import textwrap
 from unittest import TestCase
+from typing import Any
 
 import pytest
 
@@ -22,6 +23,8 @@ import jedi
 
 
 class MixinTestFullName(object):
+    assertEqual: Any
+
     operation = None
 
     @pytest.fixture(autouse=True)

test/test_api/test_interpreter.py

@@ -78,7 +78,7 @@ def test_numpy_like_non_zero():
 
 def test_nested_resolve():
     class XX:
-        def x():
+        def x():  # type: ignore[misc]
             pass
 
     cls = get_completion('XX', locals())
@@ -92,7 +92,7 @@ def test_side_effect_completion():
     Python code, however we want references to Python code as well. Therefore
     we need some mixed kind of magic for tests.
     """
-    _GlobalNameSpace.SideEffectContainer.foo = 1
+    _GlobalNameSpace.SideEffectContainer.foo = 1  # type: ignore[attr-defined]
     side_effect = get_completion('SideEffectContainer', _GlobalNameSpace.__dict__)
 
     # It's a class that contains MixedObject.
@@ -166,7 +166,7 @@ def test_getitem_side_effects():
             # Possible side effects here, should therefore not call this.
             if True:
                 raise NotImplementedError()
-            return index
+            return index  # type: ignore[unreachable]
 
     foo = Foo2()
     _assert_interpreter_complete('foo["asdf"].upper', locals(), ['upper'])
@@ -198,7 +198,7 @@ def test__getattr__completions(allow_unsafe_getattr, class_is_findable):
             raise AttributeError(name)
 
         def __dir__(self):
-            return ['foo', 'fbar'] + object.__dir__(self)
+            return ['foo', 'fbar'] + object.__dir__(self)  # type: ignore[operator]
 
     if not class_is_findable:
         CompleteGetattr.__name__ = "something_somewhere"
@@ -388,7 +388,7 @@ def test_dir_magic_method(allow_unsafe_getattr):
             raise AttributeError(name)
 
         def __dir__(self):
-            return ['foo', 'bar'] + object.__dir__(self)
+            return ['foo', 'bar'] + object.__dir__(self)  # type: ignore[operator]
 
     itp = jedi.Interpreter("ca.", [{'ca': CompleteAttrs()}])
     completions = itp.complete()
@@ -410,7 +410,7 @@ def test_dir_magic_method(allow_unsafe_getattr):
 def test_name_not_findable():
     class X():
         if 0:
-            NOT_FINDABLE  # noqa: F821
+            NOT_FINDABLE    # type: ignore[unreachable] # noqa: F821
 
         def hidden(self):
             return
@@ -493,7 +493,7 @@ def test__wrapped__():
 
 def test_illegal_class_instance():
     class X:
-        __class__ = 1
+        __class__ = 1  # type: ignore[assignment]
     X.__name__ = 'asdf'
     d, = jedi.Interpreter('foo', [{'foo': X()}]).infer()
     v, = d._name.infer()
@@ -537,7 +537,7 @@ def test_partial_signatures(code, expected, index):
 
 def test_type_var():
     """This was an issue before, see Github #1369"""
-    x = typing.TypeVar('myvar')
+    x = typing.TypeVar('myvar')  # type: ignore[misc]
     def_, = jedi.Interpreter('x', [locals()]).infer()
     assert def_.name == 'TypeVar'
 
@@ -576,7 +576,7 @@ def test_dict_completion(code, column, expected):
     strs = {'asdf': 1, """foo""": 2, r'fbar': 3}
     mixed = {1: 2, 1.10: 4, None: 6, r'a\sdf': 8, b'foo': 9}
 
-    class Inherited(dict):
+    class Inherited(dict):  # type: ignore[type-arg]
         pass
     inherited = Inherited(blablu=3)
 
@@ -624,10 +624,10 @@ def test_dunders(class_is_findable, code, expected, allow_unsafe_getattr):
         def __getitem__(self, key) -> int:
             return 1
 
-        def __iter__(self, key) -> Iterator[str]:
+        def __iter__(self, key) -> Iterator[str]:  # type: ignore[empty-body]
             pass
 
-        def __next__(self, key) -> float:
+        def __next__(self, key) -> float:  # type: ignore[empty-body]
             pass
 
     if not class_is_findable:

test/test_api/test_refactoring.py

@@ -54,7 +54,7 @@ def test_rename_mod(Script, dir_with_content):
         ''').format(dir=dir_with_content)
 
 
-@pytest.mark.skipif('sys.version_info[:2] < (3, 8)', message="Python 3.8 introduces dirs_exist_ok")
+@pytest.mark.skipif('sys.version_info[:2] < (3, 8)', reason="Python 3.8 introduces dirs_exist_ok")
 def test_namespace_package(Script, tmpdir):
     origin = get_example_dir('implicit_namespace_package')
     shutil.copytree(origin, tmpdir.strpath, dirs_exist_ok=True)

test/test_api/test_search.py

@@ -13,7 +13,7 @@ class SomeClass:
     def twice(self, b):
         pass
 
-    def some_function():
+    def some_function(self):
         pass
 
 

test/test_inference/test_docstring.py

@@ -11,14 +11,14 @@ import jedi
 from ..helpers import test_dir
 
 try:
-    import numpydoc  # NOQA
+    import numpydoc  # type: ignore[import-not-found]  # NOQA
 except ImportError:
     numpydoc_unavailable = True
 else:
     numpydoc_unavailable = False
 
 try:
-    import numpy  # NOQA
+    import numpy  # type: ignore[import-not-found]  # NOQA
 except ImportError:
     numpy_unavailable = True
 else:

test/test_inference/test_gradual/test_typeshed.py

@@ -222,7 +222,7 @@ def test_goto_stubs_on_itself(Script, code, type_):
 
 def test_module_exists_only_as_stub(Script):
     try:
-        import redis  # noqa: F401
+        import redis  # type: ignore[import-untyped]  # noqa: F401
     except ImportError:
         pass
     else:

test/test_inference/test_imports.py

@@ -30,13 +30,13 @@ def test_find_module_basic():
 
 def test_find_module_package():
     file_io, is_package = _find_module('json')
-    assert file_io.path.parts[-2:] == ('json', '__init__.py')
+    assert file_io.path.parts[-2:] == ('json', '__init__.py')  # type: ignore[union-attr]
     assert is_package is True
 
 
 def test_find_module_not_package():
     file_io, is_package = _find_module('io')
-    assert file_io.path.name == 'io.py'
+    assert file_io.path.name == 'io.py'  # type: ignore[union-attr]
     assert is_package is False
 
 

test/test_inference/test_mixed.py

@@ -56,10 +56,10 @@ def test_generics_methods(code, expected, class_findable):
     class Reader(Generic[T]):
         @classmethod
         def read(cls) -> T:
-            return cls()
+            return cls()  # type: ignore[return-value]
 
         def method(self) -> T:
-            return 1
+            return 1  # type: ignore[return-value]
 
     class Foo(Reader[str]):
         def transform(self) -> int:
@@ -94,7 +94,7 @@ def test_signature():
         pass
 
     from inspect import Signature, Parameter
-    some_signature.__signature__ = Signature([
+    some_signature.__signature__ = Signature([  # type: ignore[attr-defined]
         Parameter('bar', kind=Parameter.KEYWORD_ONLY, default=1)
     ])
 
@@ -105,7 +105,7 @@ def test_signature():
 def test_compiled_signature_annotation_string():
     import typing
 
-    def func(x: typing.Type, y: typing.Union[typing.Type, int]):
+    def func(x: typing.Type, y: typing.Union[typing.Type, int]):  # type: ignore[type-arg]
         pass
     func.__name__ = 'not_func'
 

test/test_inference/test_signature.py

@@ -2,6 +2,7 @@ from textwrap import dedent
 from operator import eq, ge, lt
 import re
 import os
+from typing import Any
 
 import pytest
 
@@ -448,7 +449,7 @@ def test_dataclass_signature(
         assert price.name == price_type_infer
 
 
-dataclass_transform_cases = [
+dataclass_transform_cases: list[Any] = [
     # Attributes on the decorated class and its base classes
     # are not considered to be fields.
     # 1/ Declare dataclass transformer

test/test_utils.py

@@ -1,7 +1,9 @@
+from typing import Any
+
 try:
     import readline
 except ImportError:
-    readline = False
+    readline = False  # type: ignore[assignment]
 import unittest
 
 from jedi import utils
@@ -15,7 +17,7 @@ class TestSetupReadline(unittest.TestCase):
     def setUp(self, *args, **kwargs):
         super().setUp(*args, **kwargs)
 
-        self.namespace = self.NameSpace()
+        self.namespace: Any = self.NameSpace()
         utils.setup_readline(self.namespace)
 
     def complete(self, text):
@@ -47,8 +49,8 @@ class TestSetupReadline(unittest.TestCase):
     def test_modules(self):
         import sys
         import os
-        self.namespace.sys = sys
+        self.namespace.sys = sys  # type: ignore[attr-defined]
-        self.namespace.os = os
+        self.namespace.os = os  # type: ignore[attr-defined]
 
         try:
             assert self.complete('os.path.join') == ['os.path.join']
@@ -58,8 +60,8 @@ class TestSetupReadline(unittest.TestCase):
             c = {'os.' + d for d in dir(os) if d.startswith('ch')}
             assert set(self.complete('os.ch')) == set(c)
         finally:
-            del self.namespace.sys
+            del self.namespace.sys  # type: ignore[attr-defined]
-            del self.namespace.os
+            del self.namespace.os  # type: ignore[attr-defined]
 
     def test_calls(self):
         s = 'str(bytes'