From d6c89ced99fc975a68e280d4bb7f2bd41464cf75 Mon Sep 17 00:00:00 2001 From: Dave Halter Date: Fri, 31 May 2019 17:41:34 +0200 Subject: [PATCH] goto should work on globals --- jedi/evaluate/finder.py | 3 ++- test/completion/basic.py | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/jedi/evaluate/finder.py b/jedi/evaluate/finder.py index 1cdacaaf..8f59868e 100644 --- a/jedi/evaluate/finder.py +++ b/jedi/evaluate/finder.py @@ -160,7 +160,8 @@ class NameFinder(object): # it's kind of hard, because for Jedi it's not clear # that that name has not been defined, yet. if n.tree_name == self._name: - if self._name.get_definition().type == 'import_from': + def_ = self._name.get_definition() + if def_ is not None and def_.type == 'import_from': continue break diff --git a/test/completion/basic.py b/test/completion/basic.py index ff5ed10e..eaea8061 100644 --- a/test/completion/basic.py +++ b/test/completion/basic.py @@ -153,6 +153,7 @@ ret()[0] # ----------------- def global_define(): + #? int() global global_var_in_func global_var_in_func = 3 @@ -168,6 +169,7 @@ def funct1(): global global_dict_var global_dict_var = dict() def funct2(): + #! ['global_dict_var', 'global_dict_var'] global global_dict_var #? dict() global_dict_var