From 034a9e89443261e7f434fcb1fbb807b14991b766 Mon Sep 17 00:00:00 2001
From: Saiyang Gou <gousaiyang@163.com>
Date: Wed, 18 Nov 2020 01:56:04 -0800
Subject: [PATCH] Properly check for invalid conversion character with f-string
 debugging syntax (#156)

---
 parso/python/errors.py   | 6 +++++-
 test/failing_examples.py | 4 ++++
 test/test_fstring.py     | 1 +
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/parso/python/errors.py b/parso/python/errors.py
index d8343c7..af601f8 100644
--- a/parso/python/errors.py
+++ b/parso/python/errors.py
@@ -957,7 +957,11 @@ class _FStringRule(SyntaxRule):
         if '\\' in expr.get_code():
             self.add_issue(expr, message=self.message_expr)
 
-        conversion = fstring_expr.children[2]
+        children_2 = fstring_expr.children[2]
+        if children_2.type == 'operator' and children_2.value == '=':
+            conversion = fstring_expr.children[3]
+        else:
+            conversion = children_2
         if conversion.type == 'fstring_conversion':
             name = conversion.children[1]
             if name.value not in ('s', 'r', 'a'):
diff --git a/test/failing_examples.py b/test/failing_examples.py
index e58b0a0..c89f1f3 100644
--- a/test/failing_examples.py
+++ b/test/failing_examples.py
@@ -357,3 +357,7 @@ if sys.version_info[:2] >= (3, 8):
         '(None := 1)',
         '(__debug__ := 1)',
     ]
+    # f-string debugging syntax with invalid conversion character
+    FAILING_EXAMPLES += [
+        "f'{1=!b}'",
+    ]
diff --git a/test/test_fstring.py b/test/test_fstring.py
index 2a07ce7..e06beee 100644
--- a/test/test_fstring.py
+++ b/test/test_fstring.py
@@ -79,6 +79,7 @@ def test_valid(code, grammar):
 
         # invalid conversion characters
         'f"{1!{a}}"',
+        'f"{1=!{a}}"',
         'f"{!{a}}"',
 
         # The curly braces must contain an expression