VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-19 02:46:01 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix flaky test_cache_last_used_update

Browse Source 
Sometimes time moves slowly and strict comparison is not enough:

```
>       assert now < node_cache_item.last_used < time.time()
E       assert 1614147958.869299 < 1614147958.869299
E        +  where 1614147958.869299 = <parso.cache._NodeCacheItem object at 0x10456fe80>.last_used
E        +  and   1614147958.869299 = <built-in function time>()
E        +    where <built-in function time> = time.time

test/test_cache.py:149: AssertionError
```

In particular, macOS timings can be a bit coarse.

The test failure is from Apple Silicon M1.
This commit is contained in:
Ivan Babrou
2021-02-23 22:27:05 -08:00
parent fac5c089ff
commit 2799a7a3c2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/test_cache.py
View File

@@ -146,7 +146,7 @@ def test_cache_last_used_update(diff_cache, use_file_io):
parse('somecode2', cache=True, path=p, diff_cache=diff_cache) parse('somecode2', cache=True, path=p, diff_cache=diff_cache)
node_cache_item = next(iter(parser_cache.values()))[p] node_cache_item = next(iter(parser_cache.values()))[p]
assert now < node_cache_item.last_used < time.time() assert now <= node_cache_item.last_used <= time.time()
@skip_pypy @skip_pypy