VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-20 11:21:18 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add issue 'non-default argument follows default argument'

Browse Source
This commit is contained in:
Dave Halter
2017-07-24 18:14:54 +02:00
parent d1eb1d61ec
commit 4e1513ae72
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
parso/python/normalizer.py
View File

@@ -33,6 +33,10 @@ def _is_future_import(import_from):
return [n.value for n in from_names] == ['__future__'] return [n.value for n in from_names] == ['__future__']
def _iter_params(parent_node):
return (n for n in parent_node.children if n.type == 'param')
def _is_future_import_first(import_from): def _is_future_import_first(import_from):
""" """
Checks if the import is the first statement of a file. Checks if the import is the first statement of a file.
@@ -173,6 +177,16 @@ class ErrorFinder(Normalizer):
if first_is_bytes != _is_bytes_literal(string): if first_is_bytes != _is_bytes_literal(string):
self._add_syntax_error(message, node) self._add_syntax_error(message, node)
break break
elif node.type in ('parameters', 'lambdef'):
default_only = False
for p in _iter_params(node):
if p.default is None:
if default_only:
# def f(x=3, y): pass
message = "non-default argument follows default argument"
self._add_syntax_error(message, node)
else:
default_only = True
yield yield

9
test/test_python_errors.py
View File

@@ -73,6 +73,12 @@ def test_indentation_errors(code, positions):
'try: pass\nexcept: pass\nexcept X: pass', 'try: pass\nexcept: pass\nexcept X: pass',
'f(x for x in bar, 1)', 'f(x for x in bar, 1)',
'from foo import a,', 'from foo import a,',
'def f(x=3, y): pass',
'lambda x=3, y: x',
#'None = 1',
#'(True,) = x',
#'([False], a) = x',
#'__debug__ = 1'
# IndentationError # IndentationError
' foo', ' foo',
@@ -82,7 +88,6 @@ def test_indentation_errors(code, positions):
] ]
) )
def test_python_exception_matches(code): def test_python_exception_matches(code):
error, = _get_error_list(code)
try: try:
compile(code, '<unknown>', 'exec') compile(code, '<unknown>', 'exec')
except (SyntaxError, IndentationError) as e: except (SyntaxError, IndentationError) as e:
@@ -94,6 +99,8 @@ def test_python_exception_matches(code):
# Python 2.6 has a bit different error messages here, so skip it. # Python 2.6 has a bit different error messages here, so skip it.
if sys.version_info[:2] == (2, 6) and wanted == 'SyntaxError: unexpected EOF while parsing': if sys.version_info[:2] == (2, 6) and wanted == 'SyntaxError: unexpected EOF while parsing':
wanted = 'SyntaxError: invalid syntax' wanted = 'SyntaxError: invalid syntax'
error, = _get_error_list(code)
assert wanted == error.message assert wanted == error.message