From 6b391af0717a78d1e8896731402bafd6fe053821 Mon Sep 17 00:00:00 2001 From: Dave Halter Date: Sun, 17 Jun 2018 16:36:27 +0200 Subject: [PATCH] Use sets instead of dicts if possible --- parso/pgen2/pgen.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/parso/pgen2/pgen.py b/parso/pgen2/pgen.py index abfad0a..4efe237 100644 --- a/parso/pgen2/pgen.py +++ b/parso/pgen2/pgen.py @@ -58,11 +58,11 @@ class ParserGenerator(object): def _make_first(self, grammar, name): rawfirst = self._first[name] - first = {} + first = set() for label in rawfirst: ilabel = self._make_label(grammar, label) - ##assert ilabel not in first # XXX failed on <> ... != - first[ilabel] = 1 + ##assert ilabel not in first, "%s failed on <> ... !=" % label + first.add(ilabel) return first def _make_label(self, grammar, label): @@ -98,7 +98,6 @@ class ParserGenerator(object): if value in grammar.keywords: return grammar.keywords[value] else: - # TODO this might be an issue?! Using token.NAME here? grammar.labels.append((token.NAME, value)) grammar.keywords[value] = ilabel return ilabel