VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-06 12:54:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update expected exception line numbers for Python 3.10.0rc1

Browse Source 
It seems that upstream has fixed line numbers in some of the expections
in Python 3.10.0rc1, so update the tests accordingly.  This means that
test_non_async_in_async() gets the correct line again,
and test_default_except_error_postition() no longer suffers from
the apparent off-by-one problem.

This doesn't fix tests entirely with Python 3.10 but it's a step
forward.
This commit is contained in:
Michał Górny
2021-08-05 09:09:28 +02:00
parent ed47650fbe
commit 7652d3904b
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/test_python_errors.py
View File

@@ -57,10 +57,10 @@ def test_non_async_in_async():
error, = errors error, = errors
actual = error.message actual = error.message
assert actual in wanted assert actual in wanted
if sys.version_info[:2] < (3, 8): if sys.version_info[:2] not in ((3, 8), (3, 9)):
assert line_nr == error.start_pos[0] assert line_nr == error.start_pos[0]
else: else:
assert line_nr == 0 # For whatever reason this is zero in Python 3.8+ assert line_nr == 0 # For whatever reason this is zero in Python 3.8/3.9
@pytest.mark.parametrize( @pytest.mark.parametrize(
@@ -140,13 +140,16 @@ def _get_actual_exception(code):
def test_default_except_error_postition(): def test_default_except_error_postition():
# For this error the position seemed to be one line off, but that doesn't # For this error the position seemed to be one line off in Python < 3.10,
# really matter. # but that doesn't really matter.
code = 'try: pass\nexcept: pass\nexcept X: pass' code = 'try: pass\nexcept: pass\nexcept X: pass'
wanted, line_nr = _get_actual_exception(code) wanted, line_nr = _get_actual_exception(code)
error, = _get_error_list(code) error, = _get_error_list(code)
assert error.message in wanted assert error.message in wanted
assert line_nr != error.start_pos[0] if sys.version_info[:2] >= (3, 10):
assert line_nr == error.start_pos[0]
else:
assert line_nr != error.start_pos[0]
# I think this is the better position. # I think this is the better position.
assert error.start_pos[0] == 2 assert error.start_pos[0] == 2