From 5570975a7db66d796924442900fd78ed0111aa62 Mon Sep 17 00:00:00 2001 From: sturmianseq Date: Wed, 18 Aug 2021 20:16:46 -0700 Subject: [PATCH 1/2] Removing state pollution in `parser_cache` --- test/test_cache.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_cache.py b/test/test_cache.py index 5e633fc..9df9b9c 100644 --- a/test/test_cache.py +++ b/test/test_cache.py @@ -188,3 +188,4 @@ def test_permission_error(monkeypatch): with pytest.warns(Warning): parse(path=__file__, cache=True, diff_cache=True) assert was_called + parser_cache.clear() From d26d0d57fe06e91dc22e89035f8b891429cdb73b Mon Sep 17 00:00:00 2001 From: sturmianseq Date: Thu, 19 Aug 2021 06:42:08 -0700 Subject: [PATCH 2/2] Applying try & finally blocks --- test/test_cache.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/test_cache.py b/test/test_cache.py index 9df9b9c..398e754 100644 --- a/test/test_cache.py +++ b/test/test_cache.py @@ -185,7 +185,9 @@ def test_permission_error(monkeypatch): was_called = False monkeypatch.setattr(cache, '_save_to_file_system', save) - with pytest.warns(Warning): - parse(path=__file__, cache=True, diff_cache=True) - assert was_called - parser_cache.clear() + try: + with pytest.warns(Warning): + parse(path=__file__, cache=True, diff_cache=True) + assert was_called + finally: + parser_cache.clear()