VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-08 05:34:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add issue 'positional argument follows keyword argument unpacking'.

Browse Source
This commit is contained in:
Dave Halter
2017-07-25 01:54:25 +02:00
parent d54d7752d4
commit babd7fca92
2 changed files with 40 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
parso/python/normalizer.py
View File

@@ -176,25 +176,46 @@ class ErrorFinder(Normalizer):
elif node.type == 'arglist':
first_arg = node.children[0]
if first_arg.type == 'argument' \
and first_arg.children[1].type == 'comp_for' \
and len(node.children) >= 2:
and first_arg.children[1].type == 'comp_for':
if len(node.children) >= 2:
# foo(x for x in [], b)
message = "Generator expression must be parenthesized if not sole argument"
self._add_syntax_error(message, node)
###
else:
arg_set = set()
for argument in node.children[::2]:
if argument.type == 'argument' and argument.children[1] == '=':
star_count = 0
kw_only = False
kw_unpacking_only = False
# In python 3 this would be a bit easier (stars are part of
# argument), but we have to understand both.
for argument in node.children:
if argument == ',':
star_count = 0
continue
if argument == '*':
star_count = len(argument.value)
continue
if argument.type == 'argument':
first = argument.children[0]
if first in ('*', '**'):
star_count = len(argument.children[0].value)
if first == '**':
kw_unpacking_only = True
else: # Is a keyword argument.
kw_only = True
keyword = argument.children[0]
if keyword.type == 'name':
if keyword.value in arg_set:
if first.type == 'name':
if first.value in arg_set:
# f(x=1, x=2)
message = "keyword argument repeated"
self._add_syntax_error(message, keyword)
self._add_syntax_error(message, first)
else:
arg_set.add(keyword.value)
arg_set.add(first.value)
else:
if kw_unpacking_only:
# f(**x, y) >= 3.5
message = "positional argument follows keyword argument unpacking"
self._add_syntax_error(message, argument)
elif node.type == 'atom':
first = node.children[0]
# e.g. 's' b''

1
test/test_python_errors.py
View File

@@ -93,6 +93,7 @@ def test_indentation_errors(code, positions):
'foo(+a=3)',
'f(lambda: 1=1)',
'f(x=1, x=2)',
'f(**x, y)',
# IndentationError
' foo',