VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-08 05:34:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add issue 'dict unpacking cannot be used in dict comprehension'

Browse Source
This commit is contained in:
Dave Halter
2017-07-23 23:47:57 +02:00
parent 915b00dab7
commit c2ab9a9e25
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
parso/python/normalizer.py
View File

@@ -212,6 +212,15 @@ class ErrorFinder(Normalizer):
if child not in (',', ')') and not child.star_count] if child not in (',', ')') and not child.star_count]
if len(after) == 0: if len(after) == 0:
self._add_syntax_error("named arguments must follow bare *", leaf) self._add_syntax_error("named arguments must follow bare *", leaf)
elif leaf.value == '**':
if leaf.parent.type == 'dictorsetmaker':
comp_for = leaf.get_next_sibling().get_next_sibling()
if comp_for is not None and comp_for.type == 'comp_for':
# {**{} for a in [1]}
message = "dict unpacking cannot be used in dict comprehension"
# TODO probably this should get a better end_pos including
# the next sibling of leaf.
self._add_syntax_error(message, leaf)
return '' return ''
def _add_indentation_error(self, message, spacing): def _add_indentation_error(self, message, spacing):

1
test/test_python_errors.py
View File

@@ -110,6 +110,7 @@ def test_python_exception_matches(code):
('def x(*): pass', '3.5'), ('def x(*): pass', '3.5'),
('async def foo():\n def nofoo():[x async for x in []]', '3.6'), ('async def foo():\n def nofoo():[x async for x in []]', '3.6'),
('[*[] for a in [1]]', '3.5'), ('[*[] for a in [1]]', '3.5'),
('{**{} for a in [1]}', '3.5'),
] ]
) )
def test_python_exception_matches_version(code, version): def test_python_exception_matches_version(code, version):