VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-09 22:25:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add issue 'duplicate argument '%s' in function definition'

Browse Source
This commit is contained in:
Dave Halter
2017-07-25 22:17:15 +02:00
parent 6a92f5ec2d
commit d6f5fcf439
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
parso/python/normalizer.py
View File

@@ -255,8 +255,14 @@ class ErrorFinder(Normalizer):
self._add_syntax_error(message, node) self._add_syntax_error(message, node)
break break
elif node.type in ('parameters', 'lambdef'): elif node.type in ('parameters', 'lambdef'):
param_names = set()
default_only = False default_only = False
for p in _iter_params(node): for p in _iter_params(node):
if p.name.value in param_names:
message = "duplicate argument '%s' in function definition"
self._add_syntax_error(message % p.name.value, p.name)
param_names.add(p.name.value)
if p.default is None: if p.default is None:
if default_only: if default_only:
# def f(x=3, y): pass # def f(x=3, y): pass

10
test/test_python_errors.py
View File

@@ -101,6 +101,9 @@ def test_indentation_errors(code, positions):
'f(**x, *y)', 'f(**x, *y)',
'f(**x, y=3, z)', 'f(**x, y=3, z)',
# SyntaxErrors from Python/symtable.c
'def f(x, x): pass',
# IndentationError # IndentationError
' foo', ' foo',
'def x():\n 1\n 2', 'def x():\n 1\n 2',
@@ -121,8 +124,11 @@ def test_python_exception_matches(code):
if sys.version_info[:2] == (2, 6) and wanted == 'SyntaxError: unexpected EOF while parsing': if sys.version_info[:2] == (2, 6) and wanted == 'SyntaxError: unexpected EOF while parsing':
wanted = 'SyntaxError: invalid syntax' wanted = 'SyntaxError: invalid syntax'
error, = _get_error_list(code) errors = _get_error_list(code)
assert wanted == error.message actual = None
if errors:
actual = errors[0].message
assert wanted == actual
@pytest.mark.parametrize( @pytest.mark.parametrize(