VimPlug/parso
1
0
Fork 0
mirror of https://github.com/davidhalter/parso.git synced 2025-12-07 13:24:39 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix trailing comma error

Browse Source
This commit is contained in:
Robin Fourcade
2019-12-04 17:21:22 +01:00
committed by Dave Halter
parent ee2995c110
commit e496b07b63
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
parso/python/errors.py
View File

@@ -586,7 +586,7 @@ class _TrailingImportComma(SyntaxRule):
message = "trailing comma not allowed without surrounding parentheses" message = "trailing comma not allowed without surrounding parentheses"
def is_issue(self, node): def is_issue(self, node):
if node.children[-1] == ',': if node.children[-1] == ',' and node.parent.children[-1] != ')':
return True return True

12
test/test_python_errors.py
View File

@@ -307,3 +307,15 @@ def test_invalid_fstrings(code, message):
""" """
error, = _get_error_list(code, version='3.6') error, = _get_error_list(code, version='3.6')
assert message in error.message assert message in error.message
@pytest.mark.parametrize(
'code', [
"from foo import (\nbar,\n rab,\n)",
"from foo import (bar, rab, )",
]
)
def test_trailing_comma(code):
errors = _get_error_list(code)
assert not errors