From 01d96e4ac49d42d5c5b52bc9d1821fcfad027b30 Mon Sep 17 00:00:00 2001 From: Daniel Shaulov Date: Sat, 16 Jan 2016 00:21:24 +0200 Subject: [PATCH] Fix signatures of __init__ for Thread and Timer --- stdlib/2.7/threading.pyi | 19 +++++++++---------- stdlib/3/threading.pyi | 19 ++++++++++--------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/stdlib/2.7/threading.pyi b/stdlib/2.7/threading.pyi index 9f8ba5ac8..6342be725 100644 --- a/stdlib/2.7/threading.pyi +++ b/stdlib/2.7/threading.pyi @@ -1,6 +1,6 @@ # Stubs for threading -from typing import Any, Dict, Optional, Callable, TypeVar, Union, List, Mapping +from typing import Any, Optional, Callable, TypeVar, Union, List, Mapping, Sequence def active_count() -> int: ... def activeCount() -> int: ... @@ -14,9 +14,9 @@ class Thread(object): ident = 0 daemon = False - def __init__(self, group: Any = ..., target: Any = ..., - name: str = ..., args: tuple = ..., - kwargs: Dict[Any, Any] = ...) -> None: ... + def __init__(self, group: Any = ..., target: Callable[..., Any] = ..., + name: str = ..., args: Sequence[Any] = ..., + kwargs: Mapping[str, Any] = ...) -> None: ... def start(self) -> None: ... def run(self) -> None: ... def join(self, timeout: float = ...) -> None: ... @@ -29,12 +29,11 @@ class Thread(object): def isDaemon(self) -> bool: ... def setDaemon(self, daemon: bool) -> None: ... -class Timer(object): - def __init__(self, interval: float, function: Any, - args: List[Any] = ..., - kwargs: Mapping[Any, Any] = ...) -> None: ... - def cancel(self) -> None: ... - def start(self) -> None: ... +class Timer(Thread): + def __init__(self, interval: float, function: Callable[..., Any], + args: Sequence[Any] = ..., + kwargs: Mapping[str, Any] = ...) -> None: ... + def cancel(self) -> None : ... # TODO: better type def settrace(func: Callable[[Any, str, Any], Any]) -> None: ... diff --git a/stdlib/3/threading.pyi b/stdlib/3/threading.pyi index a3e2597ba..16523df16 100644 --- a/stdlib/3/threading.pyi +++ b/stdlib/3/threading.pyi @@ -2,16 +2,16 @@ # NOTE: These are incomplete! -from typing import Any, Dict, Optional, Callable, TypeVar, Union +from typing import Any, Optional, Callable, TypeVar, Union, Mapping, Sequence class Thread: name = ... # type: str ident = 0 daemon = False - def __init__(self, group: Any = ..., target: Any = ..., args: Any = ..., - kwargs: Dict[Any, Any] = ..., - verbose: Any = ...) -> None: ... + def __init__(self, group: Any = ..., target: Callable[..., Any] = ..., + name: str = ..., args: Sequence[Any] = ..., + kwargs: Mapping[str, Any] = ..., daemon: bool = ...) -> None: ... def start(self) -> None: ... def run(self) -> None: ... def join(self, timeout: float = ...) -> None: ... @@ -23,6 +23,12 @@ class Thread: def isDaemon(self) -> bool: ... def setDaemon(self, daemon: bool) -> None: ... +class Timer(Thread): + def __init__(self, interval: float, function: Callable[..., Any], + args: Sequence[Any] = ..., + kwargs: Mapping[str, Any] = ...) -> None: ... + def cancel(self) -> None : ... + class Event: def is_set(self) -> bool: ... def set(self) -> None: ... @@ -54,8 +60,3 @@ class Condition: def wait_for(self, predicate: Callable[[], _T], timeout: float = ...) -> Union[_T, bool]: ... def __enter__(self) -> bool: ... def __exit__(self, *args): ... - -class Timer(Thread): - def __init__(self, interval: float, function: Callable[..., Any], - args: Any = ..., kwargs: Dict[Any, Any] = ...) -> None: ... - def cancel(self) -> None : ...