From 04100b9cec9a5a25217e5e5d45e77560ef3ced48 Mon Sep 17 00:00:00 2001 From: Jukka Lehtosalo Date: Fri, 18 Feb 2022 15:36:07 +0000 Subject: [PATCH] Improve signature of overlaps in ipaddress (#7260) The `overlaps` method returns False if the version is different: ``` import ipaddress as i v4=i.IPv4Network('10.0.0.0/8') v6=i.IPv6Network('2001:db8::2000/124') print(v6.overlaps(v4)) # False ``` --- stdlib/ipaddress.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/ipaddress.pyi b/stdlib/ipaddress.pyi index acd00b223..d777cef74 100644 --- a/stdlib/ipaddress.pyi +++ b/stdlib/ipaddress.pyi @@ -105,7 +105,7 @@ class _BaseNetwork(_IPAddressBase, Container[_A], Iterable[_A], Generic[_A]): def max_prefixlen(self) -> int: ... @property def num_addresses(self) -> int: ... - def overlaps(self, other: _BaseNetwork[_A]) -> bool: ... + def overlaps(self, other: _BaseNetwork[IPv4Address] | _BaseNetwork[IPv6Address]) -> bool: ... @property def prefixlen(self) -> int: ... if sys.version_info >= (3, 7):