From 0b1e5d3f34e6be1cf1f515d87df6ae39df72a6b1 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 15 Mar 2024 13:08:40 +0100 Subject: [PATCH] stubsabot: Skip test files in diff analysis (#11606) --- scripts/stubsabot.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/stubsabot.py b/scripts/stubsabot.py index d66018c0b..1b03180ca 100644 --- a/scripts/stubsabot.py +++ b/scripts/stubsabot.py @@ -372,11 +372,10 @@ class DiffAnalysis: @functools.cached_property def public_files_added(self) -> Sequence[str]: - return [ - file["filename"] - for file in self.py_files - if not re.match("_[^_]", Path(file["filename"]).name) and file["status"] == "added" - ] + def is_public(path: Path) -> bool: + return not re.match(r"_[^_]", path.name) and not path.name.startswith("test_") + + return [file["filename"] for file in self.py_files if is_public(Path(file["filename"])) and file["status"] == "added"] @functools.cached_property def typeshed_files_deleted(self) -> Sequence[str]: