From 15b6ace1e7548360e62b61e94ec13183038d2190 Mon Sep 17 00:00:00 2001 From: Jelle Zijlstra Date: Mon, 22 May 2017 06:34:37 -0700 Subject: [PATCH] Add to core dev guidelines (#1279) From https://github.com/python/typeshed/pull/1266#issuecomment-302916761. --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c8118f6a3..ce7b06835 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -244,3 +244,5 @@ Core developers should follow these rules when processing pull requests: * Always wait for tests to pass before merging PRs. * Use "[Squash and merge](https://github.com/blog/2141-squash-your-commits)" to merge PRs. * Delete branches for merged PRs (by core devs pushing to the main repo). +* Make sure commit messages to master are meaningful. For example, remove irrelevant + intermediate commit messages.