From 34575af8e46d301376904e8c12c42c8be281bd9f Mon Sep 17 00:00:00 2001 From: Jelle Zijlstra Date: Tue, 21 Mar 2017 08:36:00 -0700 Subject: [PATCH] Add core dev guidelines (#1058) * Add core dev guidelines * add link to "Squash and merge" --- CONTRIBUTING.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ca8ab3173..a92f9ef25 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -234,3 +234,10 @@ and labels mean. there should be no user-facing effect. * **duplicate**, **wontfix**: These identify issues that we've closed for the respective reasons. + +### Core developer guidelines + +Core developers should follow these rules when processing pull requests: + +* Always wait for tests to pass before merging PRs. +* Use "[Squash and merge](https://github.com/blog/2141-squash-your-commits)" to merge PRs.