From 3786ab295e15d4d8e77ef1512b0695bcfbb4c38f Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Mon, 20 Feb 2023 19:14:20 +0000 Subject: [PATCH] Fix an unnecessary `socketserver` allowlist entry (#9777) --- stdlib/socketserver.pyi | 6 +----- tests/stubtest_allowlists/py3_common.txt | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/stdlib/socketserver.pyi b/stdlib/socketserver.pyi index 3f0bb0eea..3d7e77f4c 100644 --- a/stdlib/socketserver.pyi +++ b/stdlib/socketserver.pyi @@ -42,14 +42,10 @@ class BaseServer: request_queue_size: int socket_type: int timeout: float | None + RequestHandlerClass: Callable[[Any, _RetAddress, Self], BaseRequestHandler] def __init__( self, server_address: _Address, RequestHandlerClass: Callable[[Any, _RetAddress, Self], BaseRequestHandler] ) -> None: ... - # It is not actually a `@property`, but we need a `Self` type: - @property - def RequestHandlerClass(self) -> Callable[[Any, _RetAddress, Self], BaseRequestHandler]: ... - @RequestHandlerClass.setter - def RequestHandlerClass(self, val: Callable[[Any, _RetAddress, Self], BaseRequestHandler]) -> None: ... def fileno(self) -> int: ... def handle_request(self) -> None: ... def serve_forever(self, poll_interval: float = 0.5) -> None: ... diff --git a/tests/stubtest_allowlists/py3_common.txt b/tests/stubtest_allowlists/py3_common.txt index fd28c8cf1..43545b649 100644 --- a/tests/stubtest_allowlists/py3_common.txt +++ b/tests/stubtest_allowlists/py3_common.txt @@ -165,7 +165,6 @@ pyexpat.expat_CAPI select.poll # Depends on configuration selectors.DevpollSelector # Depends on configuration shutil.rmtree # stubtest doesn't like that we have this as an instance of a callback protocol instead of a function -socketserver.BaseServer.RequestHandlerClass # is defined as a property, because we need `Self` type socketserver.BaseServer.fileno # implemented in derived classes socketserver.BaseServer.get_request # implemented in derived classes socketserver.BaseServer.server_bind # implemented in derived classes