From 43d4174590c6ac68c6f275140bdadbc9d3a5ea4a Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Sat, 10 Sep 2022 18:29:54 +0300 Subject: [PATCH] `SQLAlchemy`: Use `ParamSpec` for `Engine.transaction()` and `Engine.run_callable()` (#8718) --- stubs/SQLAlchemy/sqlalchemy/engine/base.pyi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/stubs/SQLAlchemy/sqlalchemy/engine/base.pyi b/stubs/SQLAlchemy/sqlalchemy/engine/base.pyi index a4f152de5..7d9f24283 100644 --- a/stubs/SQLAlchemy/sqlalchemy/engine/base.pyi +++ b/stubs/SQLAlchemy/sqlalchemy/engine/base.pyi @@ -183,12 +183,10 @@ class Engine(Connectable, Identified): ) -> None: ... def begin(self, close_with_result: bool = ...) -> _trans_ctx: ... - # TODO: - # def transaction(self, callable_: Callable[Concatenate[Connection, _P], _T], *args: _P.args, **kwargs: _P.kwargs) -> _T | None: ... - def transaction(self, callable_: Callable[..., _T], *args: Any, **kwargs: Any) -> _T | None: ... - # TODO: - # def run_callable(self, callable_: Callable[Concatenate[Connection, _P], _T], *args: _P.args, **kwargs: _P.kwargs) -> _T: ... - def run_callable(self, callable_: Callable[..., _T], *args: Any, **kwargs: Any) -> _T: ... + def transaction( + self, callable_: Callable[Concatenate[Connection, _P], _T], *args: _P.args, **kwargs: _P.kwargs + ) -> _T | None: ... + def run_callable(self, callable_: Callable[Concatenate[Connection, _P], _T], *args: _P.args, **kwargs: _P.kwargs) -> _T: ... @overload # type: ignore[override] def execute(self, statement: _Executable, *multiparams: Mapping[str, Any], **params: Any) -> CursorResult: ... @overload