From 4c20cd6711dd42383bdd6b5491f898fe504b988a Mon Sep 17 00:00:00 2001
From: Alvaro Caceres <acaceres@google.com>
Date: Mon, 1 Aug 2016 16:20:37 -0500
Subject: [PATCH] 2and3/mmap.pyi : remove "type: ignore" (#425)

First was for mypy compatibility, but is no longer needed.

Second is removed by going inheriting (Iterable[bytes],
Container[bytes], Sized, Reversible[bytes]) instead of
Sequence[bytes]. Should presumably catch more errors when using __getattr__
---
 stdlib/2and3/mmap.pyi      | 10 ++++++----
 tests/pytype_blacklist.txt |  1 -
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/stdlib/2and3/mmap.pyi b/stdlib/2and3/mmap.pyi
index b83539402..2f4978f2b 100644
--- a/stdlib/2and3/mmap.pyi
+++ b/stdlib/2and3/mmap.pyi
@@ -1,6 +1,7 @@
 # Stubs for mmap
 
-from typing import Optional, Sequence, Union, Generic, TypeVar, overload
+from typing import (Optional, Sequence, Union, Generic, TypeVar, overload,
+                    Iterable, Container, Sized, Reversible)
 import sys
 
 
@@ -37,7 +38,7 @@ class _mmap(Generic[_T]):
                      tagname: Optional[str] = ..., access: int = ...,
                      offset: int = ...) -> None: ...
     else:
-        def __init__(self,  # type: ignore
+        def __init__(self,
                      fileno: int, length: int, flags: int = ...,
                      prot: int = ..., access: int = ...,
                      offset: int = ...) -> None: ...
@@ -58,10 +59,11 @@ class _mmap(Generic[_T]):
     def __len__(self) -> int: ...
 
 if sys.version_info >= (3,):
-    class mmap(_mmap, _ContextManager[mmap], Sequence[bytes]):
+    class mmap(_mmap, _ContextManager[mmap], Iterable[bytes], Container[bytes],
+               Sized, Reversible[bytes]):
         closed = ... # type: bool
         def rfind(self, sub: bytes, start: int = ..., stop: int = ...) -> int: ...
-        @overload  # type: ignore
+        @overload
         def __getitem__(self, index: int) -> int: ...
         @overload
         def __getitem__(self, index: slice) -> bytes: ...
diff --git a/tests/pytype_blacklist.txt b/tests/pytype_blacklist.txt
index 24aaa8352..efda8fb48 100644
--- a/tests/pytype_blacklist.txt
+++ b/tests/pytype_blacklist.txt
@@ -10,5 +10,4 @@
 2and3/argparse.pyi
 2and3/logging/handlers.pyi
 2and3/logging/__init__.pyi
-2and3/mmap.pyi
 2and3/webbrowser.pyi