From 5201ccdfff86ae936e6f34ea099588b5892089e6 Mon Sep 17 00:00:00 2001 From: Jelle Zijlstra Date: Wed, 28 Mar 2018 20:24:24 -0700 Subject: [PATCH] add E741 to ignored flake8 codes (#1999) This was introduced in a recent version (so it doesn't affect us right now but will if we upgrade the flake8 version used in tests). It gives errors like: ``` /home/travis/build/ambv/flake8-pyi/.tox/typeshed/tmp/typeshed/stdlib/3/re.pyi:21:9: E741 ambiguous variable name 'I' /home/travis/build/ambv/flake8-pyi/.tox/typeshed/tmp/typeshed/stdlib/3/re.pyi:39:5: E741 ambiguous variable name 'I' /home/travis/build/ambv/flake8-pyi/.tox/typeshed/tmp/typeshed/stdlib/3/re.pyi:58:5: E741 ambiguous variable name 'I' /home/travis/build/ambv/flake8-pyi/.tox/typeshed/tmp/typeshed/third_party/2/OpenSSL/crypto.pyi:43:5: E741 ambiguous variable name 'O' ``` These aren't useful for typeshed, because regardless of whether it's good style, these libraries really do contain variables named `I` and `O`. --- .flake8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.flake8 b/.flake8 index a105e9346..4a964c8b7 100644 --- a/.flake8 +++ b/.flake8 @@ -14,7 +14,7 @@ # 34 E127 continuation line over-indented for visual indent [flake8] -ignore = F401, F403, F405, F811, E127, E128, E301, E302, E305, E501, E701, E704, B303 +ignore = F401, F403, F405, F811, E127, E128, E301, E302, E305, E501, E701, E704, E741, B303 # We are checking with Python 3 but many of the stubs are Python 2 stubs. # A nice future improvement would be to provide separate .flake8 # configurations for Python 2 and Python 3 files.