From 54392b1e121304805e7bac8c2302e32650c920d3 Mon Sep 17 00:00:00 2001
From: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Date: Mon, 29 Mar 2021 22:44:18 -0700
Subject: [PATCH] allowlist new "not a function" errors (#5155)

stubtest now checks this for overloads as well (previously it didn't,
due to some combination of laziness, that this used to short circuit and
prevent signature checking, and the fact that these are all not super
helpful)

Co-authored-by: hauntsaninja <>
---
 tests/stubtest_whitelists/py37.txt       |  1 +
 tests/stubtest_whitelists/py38.txt       |  1 +
 tests/stubtest_whitelists/py39.txt       |  2 +-
 tests/stubtest_whitelists/py3_common.txt | 14 ++++++++++++++
 4 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/tests/stubtest_whitelists/py37.txt b/tests/stubtest_whitelists/py37.txt
index 2d3dbb584..efac9b394 100644
--- a/tests/stubtest_whitelists/py37.txt
+++ b/tests/stubtest_whitelists/py37.txt
@@ -27,6 +27,7 @@ concurrent.futures.ProcessPoolExecutor.map
 contextvars.Context.__init__
 contextvars.Context.get
 contextvars.ContextVar.get
+contextlib.nullcontext  # not a function at runtime
 copy.PyStringMap
 ctypes.CDLL.__init__
 dataclasses.field
diff --git a/tests/stubtest_whitelists/py38.txt b/tests/stubtest_whitelists/py38.txt
index e73e5a635..f87e353b3 100644
--- a/tests/stubtest_whitelists/py38.txt
+++ b/tests/stubtest_whitelists/py38.txt
@@ -38,6 +38,7 @@ collections.abc.ItemsView.__reversed__
 collections.abc.KeysView.__reversed__
 collections.abc.ValuesView.__reversed__
 concurrent.futures.ProcessPoolExecutor.map
+contextlib.nullcontext  # not a function at runtime
 contextvars.Context.__init__
 contextvars.Context.get
 copy.PyStringMap
diff --git a/tests/stubtest_whitelists/py39.txt b/tests/stubtest_whitelists/py39.txt
index 51b454b3d..7b35e0619 100644
--- a/tests/stubtest_whitelists/py39.txt
+++ b/tests/stubtest_whitelists/py39.txt
@@ -45,10 +45,10 @@ collections.abc.AsyncGenerator.ag_running
 collections.abc.ItemsView.__reversed__
 collections.abc.KeysView.__reversed__
 collections.abc.ValuesView.__reversed__
+contextlib.nullcontext  # not a function at runtime
 contextvars.Context.__init__
 contextvars.Context.get
 copy.PyStringMap
-# This was changed in Python 3.9.2.
 curses.color_pair
 dataclasses.field
 dataclasses.InitVar.__class_getitem__  # stubtest bug. doesn't do the right thing with overload + implicit classmethod __class_getitem__
diff --git a/tests/stubtest_whitelists/py3_common.txt b/tests/stubtest_whitelists/py3_common.txt
index f06288ec1..cd6f93bbc 100644
--- a/tests/stubtest_whitelists/py3_common.txt
+++ b/tests/stubtest_whitelists/py3_common.txt
@@ -24,6 +24,8 @@ _collections_abc.Set.isdisjoint
 _csv.Dialect.__init__
 _dummy_threading
 _importlib_modulespec
+_operator.attrgetter  # not a function at runtime
+_operator.itemgetter  # not a function at runtime
 _operator.methodcaller
 _threading_local.local.__new__
 _typeshed.*  # Utility types for typeshed, doesn't exist at runtime
@@ -57,7 +59,9 @@ builtins.bytes.__int__
 builtins.bytes.maketrans
 builtins.classmethod.__get__
 builtins.ellipsis
+builtins.filter  # not a function at runtime
 builtins.function
+builtins.map  # not a function at runtime
 builtins.memoryview.__contains__
 builtins.memoryview.__iter__
 builtins.memoryview.cast  # inspect.signature is incorrect about shape being kw-only
@@ -66,7 +70,9 @@ builtins.property.__get__
 builtins.property.fdel
 builtins.property.fget
 builtins.property.fset
+builtins.reversed  # not a function at runtime
 builtins.staticmethod.__get__
+builtins.zip  # not a function at runtime
 bz2.BZ2Decompressor.__init__
 bz2.BZ2File.readinto
 bz2.BZ2File.readlines
@@ -247,13 +253,19 @@ ipaddress._BaseAddress.is_unspecified
 ipaddress._BaseAddress.max_prefixlen
 ipaddress._BaseAddress.packed
 ipaddress._BaseNetwork.max_prefixlen
+itertools.accumulate  # not a function at runtime
 itertools.chain.from_iterable
+itertools.combinations  # not a function at runtime
 itertools.combinations_with_replacement
 itertools.compress
 itertools.count
 itertools.dropwhile
 itertools.filterfalse
+itertools.groupby  # not a function at runtime
+itertools.islice  # not a function at runtime
 itertools.permutations
+itertools.product  # not a function at runtime
+itertools.repeat  # not a function at runtime
 itertools.starmap
 itertools.takewhile
 itertools.zip_longest
@@ -302,6 +314,8 @@ netrc.NetrcParseError.__init__
 netrc.netrc.__init__
 ntpath.join
 numbers.Number.__hash__
+operator.attrgetter  # not a function at runtime
+operator.itemgetter  # not a function at runtime
 operator.methodcaller
 optparse.HelpFormatter._format__Text
 optparse.OptionParser.__init__