All scripts/tests: always specify file encoding in calls to open() (#8882)

This commit is contained in:
Samuel T
2022-10-11 17:29:36 -04:00
committed by GitHub
parent 5ca2d77f85
commit 573ee94f35
9 changed files with 18 additions and 18 deletions

View File

@@ -71,7 +71,7 @@ def check_test_cases() -> None:
for file in testcase_dir.rglob("*.py"):
assert file.stem.startswith("check_"), bad_test_case_filename.format(file)
if package_name != "stdlib":
with open(file) as f:
with open(file, encoding="UTF-8") as f:
lines = {line.strip() for line in f}
pyright_setting_not_enabled_msg = (
f'Third-party test-case file "{file}" must have '
@@ -93,7 +93,7 @@ def check_no_symlinks() -> None:
def check_versions() -> None:
versions = set()
with open("stdlib/VERSIONS") as f:
with open("stdlib/VERSIONS", encoding="UTF-8") as f:
data = f.read().splitlines()
for line in data:
line = strip_comments(line)
@@ -128,7 +128,7 @@ def _find_stdlib_modules() -> set[str]:
def check_metadata() -> None:
for distribution in os.listdir("stubs"):
with open(os.path.join("stubs", distribution, "METADATA.toml")) as f:
with open(os.path.join("stubs", distribution, "METADATA.toml"), encoding="UTF-8") as f:
data = tomli.loads(f.read())
assert "version" in data, f"Missing version for {distribution}"
version = data["version"]
@@ -153,14 +153,14 @@ def check_metadata() -> None:
def get_txt_requirements() -> dict[str, SpecifierSet]:
with open("requirements-tests.txt") as requirements_file:
with open("requirements-tests.txt", encoding="UTF-8") as requirements_file:
stripped_lines = map(strip_comments, requirements_file)
requirements = map(Requirement, filter(None, stripped_lines))
return {requirement.name: requirement.specifier for requirement in requirements}
def get_precommit_requirements() -> dict[str, SpecifierSet]:
with open(".pre-commit-config.yaml") as precommit_file:
with open(".pre-commit-config.yaml", encoding="UTF-8") as precommit_file:
precommit = precommit_file.read()
yam = yaml.load(precommit, Loader=yaml.Loader)
precommit_requirements = {}

View File

@@ -96,7 +96,7 @@ def check_new_syntax(tree: ast.AST, path: Path, stub: str) -> list[str]:
def main() -> None:
errors = []
for path in chain(Path("stdlib").rglob("*.pyi"), Path("stubs").rglob("*.pyi")):
with open(path) as f:
with open(path, encoding="UTF-8") as f:
stub = f.read()
tree = ast.parse(stub)
errors.extend(check_new_syntax(tree, path, stub))

View File

@@ -129,7 +129,7 @@ def match(path: Path, args: TestConfig) -> bool:
def parse_versions(fname: StrPath) -> dict[str, tuple[VersionTuple, VersionTuple]]:
result = {}
with open(fname) as f:
with open(fname, encoding="UTF-8") as f:
for line in f:
line = strip_comments(line)
if line == "":

View File

@@ -19,12 +19,12 @@ from utils import colored, print_error, print_success_msg
@functools.lru_cache()
def get_mypy_req() -> str:
with open("requirements-tests.txt") as f:
with open("requirements-tests.txt", encoding="UTF-8") as f:
return next(line.strip() for line in f if "mypy" in line)
def run_stubtest(dist: Path, *, verbose: bool = False) -> bool:
with open(dist / "METADATA.toml") as f:
with open(dist / "METADATA.toml", encoding="UTF-8") as f:
metadata = dict(tomli.loads(f.read()))
print(f"{dist.name}... ", end="")

View File

@@ -101,7 +101,7 @@ def get_all_testcase_directories() -> list[PackageInfo]:
@cache
def get_gitignore_spec() -> pathspec.PathSpec:
with open(".gitignore") as f:
with open(".gitignore", encoding="UTF-8") as f:
return pathspec.PathSpec.from_lines("gitwildmatch", f.readlines())