From 57495ddaf4a144cb9befbe33bac0b6164306689c Mon Sep 17 00:00:00 2001
From: Nikita Sobolev <mail@sobolevn.me>
Date: Mon, 22 Aug 2022 17:09:01 +0300
Subject: [PATCH] Update `redis/cluster.pyi` (#8593)

---
 stubs/redis/redis/cluster.pyi | 39 +++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/stubs/redis/redis/cluster.pyi b/stubs/redis/redis/cluster.pyi
index 77ab76e3f..a21251f77 100644
--- a/stubs/redis/redis/cluster.pyi
+++ b/stubs/redis/redis/cluster.pyi
@@ -8,15 +8,15 @@ from typing_extensions import Literal
 from redis.client import CaseInsensitiveDict, PubSub, Redis, _ParseResponseOptions
 from redis.commands import CommandsParser, RedisClusterCommands
 from redis.commands.core import _StrType
-from redis.connection import BaseParser, Connection, ConnectionPool, Encoder
+from redis.connection import BaseParser, Connection, ConnectionPool, Encoder, _ConnectionPoolOptions
 from redis.exceptions import MovedError, RedisError
 from redis.typing import EncodableT
 
 def get_node_name(host: str, port: str | int) -> str: ...
-def get_connection(redis_node: Redis[Any], *args, **options) -> Connection: ...
-def parse_scan_result(command, res, **options): ...
-def parse_pubsub_numsub(command, res, **options): ...
-def parse_cluster_slots(resp, **options): ...
+def get_connection(redis_node: Redis[Any], *args, **options: _ConnectionPoolOptions) -> Connection: ...
+def parse_scan_result(command: object, res, **options): ...
+def parse_pubsub_numsub(command: object, res, **options: object): ...
+def parse_cluster_slots(resp, **options) -> dict[tuple[int, int], dict[str, Any]]: ...
 
 PRIMARY: str
 REPLICA: str
@@ -77,16 +77,19 @@ class RedisCluster(AbstractRedisCluster, RedisClusterCommands[_StrType], Generic
     def disconnect_connection_pools(self) -> None: ...
     @classmethod
     def from_url(cls: type[Self], url: str, **kwargs) -> Self: ...
-    def on_connect(self, connection) -> None: ...
-    def get_redis_connection(self, node): ...
-    def get_node(self, host: Any | None = ..., port: Any | None = ..., node_name: Any | None = ...): ...
-    def get_primaries(self): ...
-    def get_replicas(self): ...
-    def get_random_node(self): ...
-    def get_nodes(self): ...
-    def get_node_from_key(self, key, replica: bool = ...): ...
-    def get_default_node(self): ...
-    def set_default_node(self, node): ...
+    def on_connect(self, connection: Connection) -> None: ...
+    def get_redis_connection(self, node: ClusterNode) -> Redis[Any]: ...
+    def get_node(
+        self, host: str | None = ..., port: str | int | None = ..., node_name: str | None = ...
+    ) -> ClusterNode | None: ...
+    def get_primaries(self) -> list[ClusterNode]: ...
+    def get_replicas(self) -> list[ClusterNode]: ...
+    def get_random_node(self) -> ClusterNode: ...
+    def get_nodes(self) -> list[ClusterNode]: ...
+    # TODO: use type alias for `str | bytes | memoryview | bool | float`
+    def get_node_from_key(self, key: str | bytes | memoryview | bool | float, replica: bool = ...) -> ClusterNode | None: ...
+    def get_default_node(self) -> ClusterNode | None: ...
+    def set_default_node(self, node: ClusterNode | None) -> bool: ...
     def monitor(self, target_node: Any | None = ...): ...
     def pubsub(self, node: Any | None = ..., host: Any | None = ..., port: Any | None = ..., **kwargs): ...
     def pipeline(self, transaction: Any | None = ..., shard_hint: Any | None = ...): ...
@@ -100,10 +103,10 @@ class RedisCluster(AbstractRedisCluster, RedisClusterCommands[_StrType], Generic
         lock_class: type[Incomplete] | None = ...,
         thread_local: bool = ...,
     ): ...
-    def keyslot(self, key): ...
+    def keyslot(self, key: str | bytes | memoryview | bool | float) -> int: ...
     def determine_slot(self, *args): ...
-    def get_encoder(self): ...
-    def get_connection_kwargs(self): ...
+    def get_encoder(self) -> Encoder: ...
+    def get_connection_kwargs(self) -> dict[str, Any]: ...
     def execute_command(self, *args, **kwargs): ...
     def close(self) -> None: ...