From 655bca8450867e17169c14c458da5a58e3dc8256 Mon Sep 17 00:00:00 2001 From: Shantanu Date: Fri, 21 Feb 2020 20:28:47 -0800 Subject: [PATCH] xml.sax: make_parser accepts iterables in py38 (#3766) https://bugs.python.org/issue34789 --- stdlib/2and3/xml/sax/__init__.pyi | 8 ++++++-- tests/stubtest_whitelists/py38.txt | 1 - 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/stdlib/2and3/xml/sax/__init__.pyi b/stdlib/2and3/xml/sax/__init__.pyi index 68eddd642..faabf4108 100644 --- a/stdlib/2and3/xml/sax/__init__.pyi +++ b/stdlib/2and3/xml/sax/__init__.pyi @@ -1,5 +1,6 @@ -from typing import Any, List, NoReturn, Optional, Text, Union, IO +from typing import Any, Iterable, List, NoReturn, Optional, Text, Union, IO +import sys import xml.sax from xml.sax.xmlreader import InputSource, Locator from xml.sax.handler import ContentHandler, ErrorHandler @@ -23,7 +24,10 @@ class SAXReaderNotAvailable(SAXNotSupportedException): ... default_parser_list: List[str] -def make_parser(parser_list: List[str] = ...) -> xml.sax.xmlreader.XMLReader: ... +if sys.version_info >= (3, 8): + def make_parser(parser_list: Iterable[str] = ...) -> xml.sax.xmlreader.XMLReader: ... +else: + def make_parser(parser_list: List[str] = ...) -> xml.sax.xmlreader.XMLReader: ... def parse(source: Union[str, IO[str], IO[bytes]], handler: xml.sax.handler.ContentHandler, errorHandler: xml.sax.handler.ErrorHandler = ...) -> None: ... diff --git a/tests/stubtest_whitelists/py38.txt b/tests/stubtest_whitelists/py38.txt index c4b55a503..712257571 100644 --- a/tests/stubtest_whitelists/py38.txt +++ b/tests/stubtest_whitelists/py38.txt @@ -276,7 +276,6 @@ weakref.getweakrefcount webbrowser.Opera.raise_opts xml.etree.ElementTree.XMLParser.__init__ xml.etree.cElementTree.XMLParser.__init__ -xml.sax.make_parser zipfile.Path.open zipfile.ZipExtFile.__init__ zipfile.ZipExtFile.seek