From 7c5a4c96cae0bc95deab6ee710d65a6a527e7ff5 Mon Sep 17 00:00:00 2001 From: Shantanu Date: Sat, 6 Jun 2020 07:50:50 -0700 Subject: [PATCH] stubtest_unused: fix for py36 and earlier (#4187) Co-authored-by: hauntsaninja <> --- tests/stubtest_unused.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/stubtest_unused.py b/tests/stubtest_unused.py index df26e7266..f960a9d45 100755 --- a/tests/stubtest_unused.py +++ b/tests/stubtest_unused.py @@ -22,16 +22,11 @@ def main() -> int: def run_stubtest() -> List[str]: - popen = subprocess.Popen( - ["./tests/stubtest_test.py"], stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True, + proc = subprocess.run( + ["./tests/stubtest_test.py"], stdout=subprocess.PIPE, stderr=subprocess.STDOUT ) - assert popen.stdout is not None - unused = [] - for line in popen.stdout: - if line.startswith(_UNUSED_NOTE): - unused.append(line[len(_UNUSED_NOTE):].strip()) - popen.wait() - return unused + output = proc.stdout.decode("utf-8").splitlines() + return [line[len(_UNUSED_NOTE):].strip() for line in output if line.startswith(_UNUSED_NOTE)] def unused_files(unused: str) -> List[Tuple[str, str]]: