Explaining/Fixing asyncio allowlist exceptions (#5132)

tests/stubtest_whitelists/linux-py36.txt

@@ -1,4 +1,3 @@
-asyncio.unix_events._UnixSelectorEventLoop.create_unix_server
 ctypes.wintypes
 pwd.getpwnam
 ssl.PROTOCOL_SSLv3

tests/stubtest_whitelists/py36.txt

@@ -2,12 +2,12 @@ _collections_abc.AsyncGenerator.ag_await
 _collections_abc.AsyncGenerator.ag_code
 _collections_abc.AsyncGenerator.ag_frame
 _collections_abc.AsyncGenerator.ag_running
-asyncio.Future.__init__
+asyncio.Future.__init__  # Usually initialized from c object
 asyncio.exceptions  # Added in Python 3.8
 asyncio.format_helpers  # Added in Python 3.7
-asyncio.futures.Future.__init__
+asyncio.futures.Future.__init__  # Usually initialized from c object
 asyncio.futures._TracebackLogger.__init__
-asyncio.runners
+asyncio.runners  # Added in Python 3.7
 asyncio.staggered  # Added in Python 3.8
 asyncio.threads  # Added in Python 3.9
 asyncio.trsock  # Added in Python 3.8

tests/stubtest_whitelists/py37.txt

@@ -2,14 +2,12 @@ _collections_abc.AsyncGenerator.ag_await
 _collections_abc.AsyncGenerator.ag_code
 _collections_abc.AsyncGenerator.ag_frame
 _collections_abc.AsyncGenerator.ag_running
-asyncio.AbstractEventLoop.sock_sendfile
 asyncio.compat  # Removed in 3.7
-asyncio.Future.__init__
-asyncio.Future._callbacks
-asyncio.events.AbstractEventLoop.sock_sendfile
+asyncio.Future.__init__  # Usually initialized from c object
+asyncio.Future._callbacks  # Usually initialized from c object
 asyncio.exceptions  # Added in Python 3.8
-asyncio.futures.Future.__init__
-asyncio.futures.Future._callbacks
+asyncio.futures.Future.__init__  # Usually initialized from c object
+asyncio.futures.Future._callbacks  # Usually initialized from c object
 asyncio.staggered  # Added in Python 3.8
 asyncio.threads  # Added in Python 3.9
 asyncio.trsock  # Added in Python 3.8

tests/stubtest_whitelists/py38.txt

@@ -14,14 +14,11 @@ ast.Ellipsis.__new__
 ast.NameConstant.__new__
 ast.Num.__new__
 ast.Str.__new__
-asyncio.AbstractEventLoop.sock_sendfile
 asyncio.compat  # removed in 3.7
-asyncio.Future.__init__
-asyncio.Future._callbacks
-asyncio.events.AbstractEventLoop.sock_sendfile
-asyncio.futures.Future.__init__
-asyncio.futures.Future._callbacks
-asyncio.proactor_events._ProactorBasePipeTransport.__del__
+asyncio.Future.__init__  # Usually initialized from c object
+asyncio.Future._callbacks  # Usually initialized from c object
+asyncio.futures.Future.__init__  # Usually initialized from c object
+asyncio.futures.Future._callbacks  # Usually initialized from c object
 asyncio.run  # Bugfix involving this was backported to 3.8
 asyncio.runners.run  # It just hasn't been released yet
 asyncio.threads  # Added in Python 3.9

tests/stubtest_whitelists/py39.txt

@@ -24,13 +24,11 @@ ast.Index.__new__
 ast.NameConstant.__new__
 ast.Num.__new__
 ast.Str.__new__
-asyncio.AbstractEventLoop.sock_sendfile
 asyncio.compat  # module removed in 3.7
-asyncio.Future.__init__
-asyncio.Future._callbacks
-asyncio.events.AbstractEventLoop.sock_sendfile
-asyncio.futures.Future.__init__
-asyncio.futures.Future._callbacks
+asyncio.Future.__init__  # Usually initialized from c object
+asyncio.Future._callbacks  # Usually initialized from c object
+asyncio.futures.Future.__init__  # Usually initialized from c object
+asyncio.futures.Future._callbacks  # Usually initialized from c object
 asyncio.proactor_events._ProactorBasePipeTransport.__del__
 builtins.dict.get
 collections.AsyncGenerator.ag_await

tests/stubtest_whitelists/py3_common.txt

@@ -35,22 +35,18 @@ abc.abstractclassmethod
 abc.abstractmethod
 abc.abstractstaticmethod
 argparse.Namespace.__getattr__  # The whole point of this class is its attributes are dynamic
-asyncio.BaseEventLoop.subprocess_exec
+asyncio.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
+# Condition functions are exported in __init__
 asyncio.Condition.acquire
 asyncio.Condition.locked
 asyncio.Condition.release
-asyncio.Task.get_stack
-asyncio.Task.print_stack
-asyncio.base_events.BaseEventLoop.subprocess_exec
-asyncio.base_events.Server.__init__
+asyncio.base_events.BaseEventLoop.subprocess_exec # BaseEventLoop adds several parameters and stubtest fails on the difference if we add them
+# Condition functions are exported in __init__
 asyncio.locks.Condition.acquire
 asyncio.locks.Condition.locked
 asyncio.locks.Condition.release
-asyncio.proactor_events.BaseProactorEventLoop.sock_recv
-asyncio.selector_events.BaseSelectorEventLoop.sock_recv
-asyncio.streams.FlowControlMixin.__init__
-asyncio.tasks.Task.get_stack
-asyncio.tasks.Task.print_stack
+asyncio.proactor_events.BaseProactorEventLoop.sock_recv # nbytes parameter has different name 'n' in implementation
+asyncio.selector_events.BaseSelectorEventLoop.sock_recv # nbytes parameter has different name 'n' in implementation
 builtins.bytearray.__float__
 builtins.bytearray.__int__
 builtins.bytearray.append