VimPlug/typeshed
1
0
Fork 0
mirror of https://github.com/davidhalter/typeshed.git synced 2025-12-07 12:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

typing.pyi: Improve comments for IO/TextIO (#8913)

Browse Source 
#8726 proposed to make these properties abstract, but it would have broken half the typed-Python ecosystem, and we've since decided that it's not worth taking action on this (https://github.com/python/typeshed/issues/2146#event-7450564547). This PR rephrases the comments to make clear that there isn't really anything actionable that can be done here.
This commit is contained in:
Alex Waygood
2022-10-17 11:44:40 +01:00
committed by GitHub
parent 2b5afd9cc9
commit 928f006318
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
stdlib/typing.pyi
View File

@@ -638,7 +638,9 @@ TYPE_CHECKING: bool
# This differs from runtime, but better reflects the fact that in reality
# classes deriving from IO use different names for the arguments.
class IO(Iterator[AnyStr], Generic[AnyStr]):
# TODO use abstract properties
# At runtime these are all abstract properties,
# but making them abstract in the stub is hugely disruptive, for not much gain.
# See #8726
@property
def mode(self) -> str: ...
@property
@@ -691,7 +693,7 @@ class BinaryIO(IO[bytes]):
def __enter__(self) -> BinaryIO: ...
class TextIO(IO[str]):
# TODO use abstractproperty
# See comment regarding the @properties in the `IO` class
@property
def buffer(self) -> BinaryIO: ...
@property