From aa885ecd6581170837700dd0588feed447207c02 Mon Sep 17 00:00:00 2001 From: Nipunn Koorapati Date: Tue, 18 Jan 2022 06:58:48 -0800 Subject: [PATCH] Flatten stubtest_allowlist for protobuf generated files (#6944) I added stubtest testing for generated files within mypy-protobuf. There are many ways in which the protobuf code is doing *weird* things and we want the stubs to look a bit different. They're enumerated in the `stubtest_allowlist.txt` of mypy-protobuf, so squashing them here so that this one can focus on the non-generated files. --- stubs/protobuf/@tests/stubtest_allowlist.txt | 152 +------------------ 1 file changed, 4 insertions(+), 148 deletions(-) diff --git a/stubs/protobuf/@tests/stubtest_allowlist.txt b/stubs/protobuf/@tests/stubtest_allowlist.txt index 5c52da428..210b29756 100644 --- a/stubs/protobuf/@tests/stubtest_allowlist.txt +++ b/stubs/protobuf/@tests/stubtest_allowlist.txt @@ -1,103 +1,13 @@ +# Generated pb2 methods diverge for a variety of reasons. They are tested +# carefully in mypy-protobuf which internally runs stubtest. Skip those here. +google.protobuf\..*_pb2\..* + google.protobuf.__version__ -google.protobuf.any_pb2.Any.__init__ -google.protobuf.api_pb2.Api.__init__ -google.protobuf.api_pb2.Method.__init__ -google.protobuf.api_pb2.Mixin.__init__ -google.protobuf.compiler.plugin_pb2.CodeGeneratorRequest.__init__ -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse.FEATURE_NONE -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse.FEATURE_PROTO3_OPTIONAL -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse.Feature -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse.File.__init__ -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse._Feature -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse._FeatureEnumTypeWrapper -google.protobuf.compiler.plugin_pb2.CodeGeneratorResponse.__init__ -google.protobuf.compiler.plugin_pb2.Version.__init__ google.protobuf.descriptor.Descriptor.__new__ google.protobuf.descriptor.FieldDescriptor.__init__ google.protobuf.descriptor.FieldDescriptor.__new__ google.protobuf.descriptor.ServiceDescriptor.__new__ google.protobuf.descriptor._NestedDescriptorBase.GetTopLevelContainingType -google.protobuf.descriptor_pb2.DescriptorProto.ExtensionRange.__init__ -google.protobuf.descriptor_pb2.DescriptorProto.ReservedRange.__init__ -google.protobuf.descriptor_pb2.DescriptorProto.__init__ -google.protobuf.descriptor_pb2.EnumDescriptorProto.EnumReservedRange.__init__ -google.protobuf.descriptor_pb2.EnumDescriptorProto.__init__ -google.protobuf.descriptor_pb2.EnumOptions.__init__ -google.protobuf.descriptor_pb2.EnumValueDescriptorProto.__init__ -google.protobuf.descriptor_pb2.EnumValueOptions.__init__ -google.protobuf.descriptor_pb2.ExtensionRangeOptions.__init__ -google.protobuf.descriptor_pb2.FieldDescriptorProto.LABEL_OPTIONAL -google.protobuf.descriptor_pb2.FieldDescriptorProto.LABEL_REPEATED -google.protobuf.descriptor_pb2.FieldDescriptorProto.LABEL_REQUIRED -google.protobuf.descriptor_pb2.FieldDescriptorProto.Label -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_BOOL -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_BYTES -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_DOUBLE -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_ENUM -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_FIXED32 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_FIXED64 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_FLOAT -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_GROUP -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_INT32 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_INT64 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_MESSAGE -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_SFIXED32 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_SFIXED64 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_SINT32 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_SINT64 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_STRING -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_UINT32 -google.protobuf.descriptor_pb2.FieldDescriptorProto.TYPE_UINT64 -google.protobuf.descriptor_pb2.FieldDescriptorProto.Type -google.protobuf.descriptor_pb2.FieldDescriptorProto._Label -google.protobuf.descriptor_pb2.FieldDescriptorProto._LabelEnumTypeWrapper -google.protobuf.descriptor_pb2.FieldDescriptorProto._Type -google.protobuf.descriptor_pb2.FieldDescriptorProto._TypeEnumTypeWrapper -google.protobuf.descriptor_pb2.FieldDescriptorProto.__init__ -google.protobuf.descriptor_pb2.FieldOptions.CORD -google.protobuf.descriptor_pb2.FieldOptions.CType -google.protobuf.descriptor_pb2.FieldOptions.JSType -google.protobuf.descriptor_pb2.FieldOptions.JS_NORMAL -google.protobuf.descriptor_pb2.FieldOptions.JS_NUMBER -google.protobuf.descriptor_pb2.FieldOptions.JS_STRING -google.protobuf.descriptor_pb2.FieldOptions.STRING -google.protobuf.descriptor_pb2.FieldOptions.STRING_PIECE -google.protobuf.descriptor_pb2.FieldOptions._CType -google.protobuf.descriptor_pb2.FieldOptions._CTypeEnumTypeWrapper -google.protobuf.descriptor_pb2.FieldOptions._JSType -google.protobuf.descriptor_pb2.FieldOptions._JSTypeEnumTypeWrapper -google.protobuf.descriptor_pb2.FieldOptions.__init__ -google.protobuf.descriptor_pb2.FileDescriptorProto.__init__ -google.protobuf.descriptor_pb2.FileDescriptorSet.__init__ -google.protobuf.descriptor_pb2.FileOptions.CODE_SIZE -google.protobuf.descriptor_pb2.FileOptions.LITE_RUNTIME -google.protobuf.descriptor_pb2.FileOptions.OptimizeMode -google.protobuf.descriptor_pb2.FileOptions.SPEED -google.protobuf.descriptor_pb2.FileOptions._OptimizeMode -google.protobuf.descriptor_pb2.FileOptions._OptimizeModeEnumTypeWrapper -google.protobuf.descriptor_pb2.FileOptions.__init__ -google.protobuf.descriptor_pb2.GeneratedCodeInfo.Annotation.__init__ -google.protobuf.descriptor_pb2.GeneratedCodeInfo.__init__ -google.protobuf.descriptor_pb2.MessageOptions.__init__ -google.protobuf.descriptor_pb2.MethodDescriptorProto.__init__ -google.protobuf.descriptor_pb2.MethodOptions.IDEMPOTENCY_UNKNOWN -google.protobuf.descriptor_pb2.MethodOptions.IDEMPOTENT -google.protobuf.descriptor_pb2.MethodOptions.IdempotencyLevel -google.protobuf.descriptor_pb2.MethodOptions.NO_SIDE_EFFECTS -google.protobuf.descriptor_pb2.MethodOptions._IdempotencyLevel -google.protobuf.descriptor_pb2.MethodOptions._IdempotencyLevelEnumTypeWrapper -google.protobuf.descriptor_pb2.MethodOptions.__init__ -google.protobuf.descriptor_pb2.OneofDescriptorProto.__init__ -google.protobuf.descriptor_pb2.OneofOptions.__init__ -google.protobuf.descriptor_pb2.ServiceDescriptorProto.__init__ -google.protobuf.descriptor_pb2.ServiceOptions.__init__ -google.protobuf.descriptor_pb2.SourceCodeInfo.Location.__init__ -google.protobuf.descriptor_pb2.SourceCodeInfo.__init__ -google.protobuf.descriptor_pb2.UninterpretedOption.NamePart.__init__ -google.protobuf.descriptor_pb2.UninterpretedOption.__init__ -google.protobuf.duration_pb2.Duration.__init__ -google.protobuf.empty_pb2.Empty.__init__ -google.protobuf.field_mask_pb2.FieldMask.__init__ google.protobuf.internal.containers.BaseContainer.sort google.protobuf.internal.containers.MessageMap.__init__ google.protobuf.internal.containers.MessageMap.get @@ -122,58 +32,4 @@ google.protobuf.message.Message.SerializePartialToString google.protobuf.message.Message.SerializeToString google.protobuf.message.Message.__init__ google.protobuf.service.Service.GetDescriptor -google.protobuf.source_context_pb2.SourceContext.__init__ -google.protobuf.struct_pb2.ListValue.__init__ -google.protobuf.struct_pb2.NULL_VALUE -google.protobuf.struct_pb2.NullValue -google.protobuf.struct_pb2.Struct.FieldsEntry.__init__ -google.protobuf.struct_pb2.Struct.__init__ -google.protobuf.struct_pb2.Value.__init__ google.protobuf.text_format.MessageToBytes -google.protobuf.timestamp_pb2.Timestamp.__init__ -google.protobuf.type_pb2.Enum.__init__ -google.protobuf.type_pb2.EnumValue.__init__ -google.protobuf.type_pb2.Field.CARDINALITY_OPTIONAL -google.protobuf.type_pb2.Field.CARDINALITY_REPEATED -google.protobuf.type_pb2.Field.CARDINALITY_REQUIRED -google.protobuf.type_pb2.Field.CARDINALITY_UNKNOWN -google.protobuf.type_pb2.Field.Cardinality -google.protobuf.type_pb2.Field.Kind -google.protobuf.type_pb2.Field.TYPE_BOOL -google.protobuf.type_pb2.Field.TYPE_BYTES -google.protobuf.type_pb2.Field.TYPE_DOUBLE -google.protobuf.type_pb2.Field.TYPE_ENUM -google.protobuf.type_pb2.Field.TYPE_FIXED32 -google.protobuf.type_pb2.Field.TYPE_FIXED64 -google.protobuf.type_pb2.Field.TYPE_FLOAT -google.protobuf.type_pb2.Field.TYPE_GROUP -google.protobuf.type_pb2.Field.TYPE_INT32 -google.protobuf.type_pb2.Field.TYPE_INT64 -google.protobuf.type_pb2.Field.TYPE_MESSAGE -google.protobuf.type_pb2.Field.TYPE_SFIXED32 -google.protobuf.type_pb2.Field.TYPE_SFIXED64 -google.protobuf.type_pb2.Field.TYPE_SINT32 -google.protobuf.type_pb2.Field.TYPE_SINT64 -google.protobuf.type_pb2.Field.TYPE_STRING -google.protobuf.type_pb2.Field.TYPE_UINT32 -google.protobuf.type_pb2.Field.TYPE_UINT64 -google.protobuf.type_pb2.Field.TYPE_UNKNOWN -google.protobuf.type_pb2.Field._Cardinality -google.protobuf.type_pb2.Field._CardinalityEnumTypeWrapper -google.protobuf.type_pb2.Field._Kind -google.protobuf.type_pb2.Field._KindEnumTypeWrapper -google.protobuf.type_pb2.Field.__init__ -google.protobuf.type_pb2.Option.__init__ -google.protobuf.type_pb2.SYNTAX_PROTO2 -google.protobuf.type_pb2.SYNTAX_PROTO3 -google.protobuf.type_pb2.Syntax -google.protobuf.type_pb2.Type.__init__ -google.protobuf.wrappers_pb2.BoolValue.__init__ -google.protobuf.wrappers_pb2.BytesValue.__init__ -google.protobuf.wrappers_pb2.DoubleValue.__init__ -google.protobuf.wrappers_pb2.FloatValue.__init__ -google.protobuf.wrappers_pb2.Int32Value.__init__ -google.protobuf.wrappers_pb2.Int64Value.__init__ -google.protobuf.wrappers_pb2.StringValue.__init__ -google.protobuf.wrappers_pb2.UInt32Value.__init__ -google.protobuf.wrappers_pb2.UInt64Value.__init__