VimPlug/typeshed
1
0 Fork 0
mirror of https://github.com/davidhalter/typeshed.git synced 2026-10-20 04:37:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add review guidlines (#4132)

Browse Source 
Closes: #3448
This commit is contained in:
Sebastian Rittau authored and GitHub committed 2020-05-28 15:18:05 +02:00
1 parent 313a835bea
commit adafaf1964
1 file changed
+10
Download Patch File Download Diff File Expand all files Collapse all files
CONTRIBUTING.md
+10
View File
@@ -373,3 +373,13 @@ Core developers should follow these rules when processing pull requests:
* Make sure commit messages to master are meaningful. For example, remove irrelevant
intermediate commit messages.
* If stubs for a new library are submitted, notify the library's maintainers.
When reviewing PRs, follow these guidelines:
* Typing is hard. Try to be helpful and explain issues with the PR,
especially to new contributors.
* When reviewing auto-generated stubs, just scan for red flags and obvious
errors. Leave possible manual improvements for separate PRs.
* When reviewing large, hand-crafted PRs, you only need to look for red flags
and general issues, and do a few spot checks.
* Review smaller, hand-crafted PRs thoroughly.