From afeecb478b69f3e73e757d0868f158099acf0dce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Santos?= Date: Sun, 25 Mar 2018 17:11:01 +0200 Subject: [PATCH] RotatingFileHandler has a terminator property (#1952) In python3 `RotatingFileHandler` is a subclass of `BaseRotatingHandler` which is a subclass of `FileHandler` which is a subclass of `StreamHandler` which as a `terminator` property but I'm getting a `"RotatingFileHandler" has no attribute "terminator"` error on my code. --- stdlib/2and3/logging/handlers.pyi | 1 + 1 file changed, 1 insertion(+) diff --git a/stdlib/2and3/logging/handlers.pyi b/stdlib/2and3/logging/handlers.pyi index 0dcaee9c1..92fb3baf7 100644 --- a/stdlib/2and3/logging/handlers.pyi +++ b/stdlib/2and3/logging/handlers.pyi @@ -29,6 +29,7 @@ class WatchedFileHandler(Handler): if sys.version_info >= (3,): class BaseRotatingHandler(FileHandler): + terminator = ... # type: str namer = ... # type: Optional[Callable[[str], str]] rotator = ... # type: Optional[Callable[[str, str], None]] def __init__(self, filename: str, mode: str,