From aff821c538d92cc6d328b7895d6abb69bf7d2a10 Mon Sep 17 00:00:00 2001 From: Jukka Lehtosalo Date: Fri, 30 Apr 2021 14:15:13 +0100 Subject: [PATCH] Improve requests.adapters.HttpAdapter.__init__ (#5266) The `max_retries` argument can be `None`. It's handled here as `retries`: https://github.com/urllib3/urllib3/blob/main/src/urllib3/util/retry.py#L235 --- stubs/requests/requests/adapters.pyi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/stubs/requests/requests/adapters.pyi b/stubs/requests/requests/adapters.pyi index 3547f2b41..b7309e05d 100644 --- a/stubs/requests/requests/adapters.pyi +++ b/stubs/requests/requests/adapters.pyi @@ -53,7 +53,11 @@ class HTTPAdapter(BaseAdapter): config: Any proxy_manager: Any def __init__( - self, pool_connections: int = ..., pool_maxsize: int = ..., max_retries: Union[Retry, int] = ..., pool_block: bool = ... + self, + pool_connections: int = ..., + pool_maxsize: int = ..., + max_retries: Union[Retry, int, None] = ..., + pool_block: bool = ..., ) -> None: ... poolmanager: Any def init_poolmanager(self, connections, maxsize, block=..., **pool_kwargs): ...