From b08a2e6dea8a2f4bfa13d22dcfb54fabb4dde97e Mon Sep 17 00:00:00 2001 From: Jukka Lehtosalo Date: Wed, 19 May 2021 11:56:18 +0100 Subject: [PATCH] Fix Python 2 genericpath.commonprefix (#5500) The more specific overload item should come first. Also fix the return type. --- stdlib/@python2/genericpath.pyi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stdlib/@python2/genericpath.pyi b/stdlib/@python2/genericpath.pyi index 72e6b7a24..f1d3538cd 100644 --- a/stdlib/@python2/genericpath.pyi +++ b/stdlib/@python2/genericpath.pyi @@ -6,10 +6,10 @@ from typing_extensions import Literal # Iterable[T], so that Union[List[T], Literal[""]] could be used as a return # type. But because this only works when T is str, we need Sequence[T] instead. @overload -def commonprefix(m: Sequence[Text]) -> str: ... # type: ignore -@overload def commonprefix(m: Sequence[str]) -> Union[str, Literal[""]]: ... # type: ignore @overload +def commonprefix(m: Sequence[Text]) -> Text: ... # type: ignore +@overload def commonprefix(m: Sequence[List[SupportsLessThanT]]) -> Sequence[SupportsLessThanT]: ... @overload def commonprefix(m: Sequence[Tuple[SupportsLessThanT, ...]]) -> Sequence[SupportsLessThanT]: ...