From b3b8daed2e9907dd221c94c428e57741f29676e6 Mon Sep 17 00:00:00 2001 From: Jukka Lehtosalo Date: Thu, 15 Jul 2021 12:24:46 +0100 Subject: [PATCH] Fix import sorting in create_baseline_stubs script (#5781) Run isort before black since changes made by isort don't follow stub conventions. --- scripts/create_baseline_stubs.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/create_baseline_stubs.py b/scripts/create_baseline_stubs.py index e95536da4..e00cb8766 100644 --- a/scripts/create_baseline_stubs.py +++ b/scripts/create_baseline_stubs.py @@ -66,8 +66,8 @@ def run_black(stub_dir: str) -> None: def run_isort(stub_dir: str) -> None: - print(f"Running isort: isort --recursive {stub_dir}") - subprocess.run(["isort", "--recursive", stub_dir]) + print(f"Running isort: isort {stub_dir}") + subprocess.run(["python3", "-m", "isort", stub_dir]) def create_metadata(stub_dir: str, version: str) -> None: @@ -150,8 +150,8 @@ def main() -> None: # Stubs were generated under out/. Copy them to stubs/. copy_stubs("out", package, stub_dir) - run_black(stub_dir) run_isort(stub_dir) + run_black(stub_dir) create_metadata(stub_dir, version)