From c58a93b928b07a5123fa8ceebe6087fa262fe238 Mon Sep 17 00:00:00 2001 From: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Date: Fri, 30 Oct 2020 01:16:11 -0700 Subject: [PATCH] mypy_primer: speed up, clean up (#4730) We use tee and no longer try to delete the file based on exit code, since we use data.trim now. mypy_primer started failing silently because of changes in aiohttp, so now we'll fail if the exit codes are not 0 or 1. Note mypy_primer has --project-date to get around the problem of breaking changes in projects, but I want to try and keep mypy_primer up to date / get a feel for how bad this problem actually is. Co-authored-by: hauntsaninja <> --- .github/workflows/mypy_primer.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/mypy_primer.yml b/.github/workflows/mypy_primer.yml index 72ec3efd0..b8d98504e 100644 --- a/.github/workflows/mypy_primer.yml +++ b/.github/workflows/mypy_primer.yml @@ -35,8 +35,7 @@ jobs: git rev-list --format=%s --max-count=1 upstream_master echo '' cd .. - ( mypy_primer --new v0.790 --old v0.790 --custom-typeshed-repo typeshed_to_test --new-typeshed $COMMIT --old-typeshed upstream_master -o concise > diff.txt && rm diff.txt ) || true - cat diff.txt || true + ( mypy_primer --new 0.790 --old 0.790 --custom-typeshed-repo typeshed_to_test --new-typeshed $COMMIT --old-typeshed upstream_master -o concise | tee diff.txt ) || [ $? -eq 1 ] - name: Post comment uses: actions/github-script@v3 with: