From f207bc3cc3e41c88c1c138fbcc65e4c54316d6f2 Mon Sep 17 00:00:00 2001 From: Elliott Beach Date: Tue, 16 Jan 2018 18:26:48 -0600 Subject: [PATCH] add note about not squashing (#1830) --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f9fec6c5..87164560c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -75,6 +75,9 @@ processed incorrectly by a type checker. It is also helpful to add links to online documentation or to the implementation of the code you are changing. +Also, do not squash your commits after you have submitted a pull request, as this +erases context during review. We will squash commits when the pull request is merged. + At present the core developers are (alphabetically): * David Fisher (@ddfisher) * Łukasz Langa (@ambv)