From fc0db5f2b6d760f289523a56ed2d396ab6eed059 Mon Sep 17 00:00:00 2001 From: Jelle Zijlstra Date: Sun, 11 Apr 2021 06:50:08 -0700 Subject: [PATCH] Add a suggestion to CONTRIBUTING.md (#5205) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c965b9909..f25b7793e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -339,6 +339,9 @@ harmless. This is a strictly better compromise than using the latter two forms, which would generate false positive errors for correct use under Python 3.7.4. +When your stub contains if statements for different Python versions, +always put the code for the most recent Python version first. + Note: in its current implementation, typeshed cannot contain stubs for multiple versions of the same third-party library. Prefer to generate stubs for the latest version released on PyPI at the time of your