Fixes#7344 for now.
As discussed in that issue, I think it might make sense to revert the
change to check positional-only arguments on dunders for now, since it
seems to be mostly busywork and has very little benefit for end users.
However, that'll happen on stubtest master, which typeshed isn't yet
ready for.
Co-authored-by: hauntsaninja <>
If pre-commit makes a change immediately after a PR has been made, it's important that the stubtest/mypy/pytype/pyright checks are run again, as line numbers might have changed. However, there's no reason to start a new run of mypy_primer, since pre-commit will make no substantive changes to a PR, only cosmetic changes, and that shouldn't affect the diff from mypy_primer.
This is consistent with the runtime definition: https://github.com/python/cpython/blob/main/Lib/typing.py#L434.
The previous definition was wrong; NoReturn is not and should not be equivalent to None. This fixes an issue in pyanalyze where it was interpreting NoReturn as equivalent to None.
* Added initial rework of the concurrent.futures module
* Minor fixes
* Fixed some generics & changed to collections over typing for some types
* Switched thread to use queues instead of multiprocessing.queues
* More fixes
* More fixes following results from running tests locally
* Tmp commit of changes
* Minor flake8 fix
* Fixing some issues
* Fixed a weakref.ref issue
* Fixed one more weakref issue
* Fixed some issues with required version
* Fixed more python min version requirements
* More min version fixes
* Fixed misc error in workflow regarded outdated pip
* Replaced any usage of Optional and Union with proper form as described in the contributions guide
* Fixed issue with using Callable definition
* Fixed last seen issues as per review
* Fixed some basic issues & more proper import calls
* Update stdlib/concurrent/futures/process.pyi
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
* Update stdlib/concurrent/futures/process.pyi
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
* Minor fixes
* More minor fixes
* Fixed up some issues & cleaned up imports
* Removed usage of Union
* Changed wait method to use Set of Future to work with mypy-primer for Optuna repo
* Reverted change to wait method and DoneAndNotDoneFutures class
* Fixed DoneAndNotDoneFutures again
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
* Updated pyright version to 1.1.160. Older versions contained a bug that prevented multiple third-party stub packages from having the same top-level module name.
* Disabled "reportUnsupportedDunderAll" diagnostic check for now.
Co-authored-by: Eric Traut <erictr@microsoft.com>
