Commit Graph
47 Commits
Author SHA1 Message Date
ShantanuandGitHub 31b6d415dc mypy_primer: check conclusion field as well (#5272)
Fixes #5270

The comment workflow waits for the mypy primer to run. I think with
Github's changes to workflow running, these runs get marked as
completed, but have the conclusion "action_required".
E.g., see https://github.com/python/typeshed/pull/5269/checks
2021-04-30 18:07:28 -07:00
Jake BaileyandGitHub 413276f411 Use pyright-action to run pyright, bump pyright (#5274)
I recently published https://github.com/marketplace/actions/run-pyright, which wraps pyright and uses GHA magic to leave diagnostics on commits / PRs (like https://github.com/jakebailey/pyright-action-test/pull/1/files), plus a faster startup time thanks to GHA tool caching and piggy backing off of the `node` install used in GHA itself (so no `setup-node` needed).

This PR switches to that action and leaves a comment noting that the version number is pinned in two places.

This action is a prototype, but I'm pretty confident in it so far.
2021-04-30 18:06:58 -07:00
Jelle ZijlstraandGitHub 2c8cb60596 Fix permissions for mypy-primer-comments (#5259)
Based on https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#permissions
2021-04-27 18:05:20 +02:00
Sebastian RittauandGitHub f1cd416dcf Allow comments workflow appropriate permission (#5258) 2021-04-27 00:58:56 -07:00
Sebastian RittauandGitHub 7ca219f9c4 Add permissions to all workflows (#5255) 2021-04-26 16:51:35 +02:00
Sebastian RittauandGitHub ba0f2b929b Always generate a comment for mypy_primer (#5197)
This way, runs without output after runs with output can be clearly
determined. This also makes it easier to recognize when a run was not
completed.
2021-04-15 09:18:13 +02:00
Jake BaileyandGitHub f626da6553 Bump pyright to 1.1.126, enable 3.10 testing (#5153) 2021-03-30 11:57:55 -07:00
Sebastian RittauandGitHub 2b19c761ec Fix build (#5086)
Run the mypy test suite using Ubuntu 18.04. Ubuntu 20.04 doesn't have a package for virtualenv on Python 2.

Also, curses.color_pair() now has a named argument.
2021-03-04 17:11:37 +01:00
Jake BaileyandGitHub 0fa7e73027 Run pyright on matrix of platforms and python versions (#5072)
* Run pyright on matrix of platforms and python versions

* Drop 3.10 from matrix, as it fails
2021-02-25 16:24:32 -08:00
c00c7258ea Add pyright to test suite, pyrightconfig.json (#5059)
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
2021-02-23 23:07:42 +01:00
ShantanuGitHubhauntsaninja <>
1959669aa4 mypy_primer: don't fail silently on comment failure (#5002)
Co-authored-by: hauntsaninja <>
2021-02-03 08:35:38 +01:00
e2fd852952 Add more consistency tests (#4983)
Follow up fo #4971

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
2021-01-29 17:23:35 +00:00
ShantanuandGitHub c39f8b942b Run mypy_primer with a newer mypy (#4980) 2021-01-28 20:03:16 -08:00
ShantanuandGitHub d7bbc9ea67 Re-enable stubtest (#4979) 2021-01-28 05:22:55 -08:00
Rebecca ChenandGitHub ce24720a1a Fix and re-enable pytype_test (#4975)
For now, the test requires changes that have been merged into the pytype master branch but not yet released. I'll update requirements-tests-py3.txt again once I've cut a new release (hopefully later this week).

* Fix pytype_test.
* Re-enable pytype_test.
* Remove continue-on-error from pytype_test.
* Temporarily install pytype from its master branch, as the code to
  support the new directory structure hasn't been released yet.
* Set TYPESHED_HOME before using pytype.pytd.Typeshed().
2021-01-27 22:00:27 +00:00
16ae4c6120 Re-organize directory structure (#4971)
See discussion in #2491

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
2021-01-27 12:00:39 +00:00
ShantanuGitHubhauntsaninja <>
12f0be025f mypy_primer: shard across two CI jobs (#4865)
Co-authored-by: hauntsaninja <>
2020-12-28 11:17:39 +01:00
ShantanuGitHubhauntsaninja <>
e035760d62 Return mypy_primer to CI (#4806)
Much of the comment script is based off of https://github.com/dawidd6/action-download-artifact

Co-authored-by: hauntsaninja <>
2020-12-14 18:31:30 +01:00
ShantanuGitHubhauntsaninja <>
74147313cd Remove mypy_primer (#4795)
Co-authored-by: hauntsaninja <>
2020-11-29 23:03:42 -08:00
ShantanuGitHubhauntsaninja <>
20446030c5 Fix stubtest unused cron job (#4782)
Co-authored-by: hauntsaninja <>
2020-11-21 19:36:27 +01:00
Sebastian RittauandGitHub d2a7889fe0 Drop support for Python 3.5 (#4675)
Python 3.5 EOL was on 2020-09-30.
2020-11-02 16:18:20 +01:00
ShantanuGitHubhauntsaninja <>
620989bac5 typeshed: update stubtest version (#4739)
* typeshed: update stubtest version

Includes changes from https://github.com/python/mypy/pull/9680
I've already fixed all the true positives on typeshed.

* attempt to fix windows' _WarnFunction

Co-authored-by: hauntsaninja <>
2020-11-01 12:35:21 +01:00
ShantanuGitHubhauntsaninja <>
c58a93b928 mypy_primer: speed up, clean up (#4730)
We use tee and no longer try to delete the file based on exit code,
since we use data.trim now.
mypy_primer started failing silently because of changes in aiohttp, so
now we'll fail if the exit codes are not 0 or 1.
Note mypy_primer has --project-date to get around the problem of
breaking changes in projects, but I want to try and keep mypy_primer up
to date / get a feel for how bad this problem actually is.

Co-authored-by: hauntsaninja <>
2020-10-30 09:16:11 +01:00
Sebastian RittauandGitHub c5aca0d533 Only add a mypy_primer comment if there is output (#4725) 2020-10-28 20:07:12 +01:00
ShantanuGitHubhauntsaninja <>
25b3004ad8 mypy_primer: post a more informative message (#4719)
Co-authored-by: hauntsaninja <>
2020-10-27 07:47:59 +01:00
ShantanuGitHubhauntsaninja <>
fc171339ce mypy_primer: attempt to fix workflow (#4718)
This will take some merge and debug...

Co-authored-by: hauntsaninja <>
2020-10-26 13:03:08 -07:00
ShantanuGitHubhauntsaninja <>
1bd808a458 mypy_primer: post failures as comments (#4672)
Co-authored-by: hauntsaninja <>
2020-10-26 10:58:49 +01:00
ShantanuGitHubhauntsaninja <>
8d4a4f9e74 mypy_selftest: rename to mypy_self_check (#4712)
This better disambiguates it from mypy_test_suite and is more inline
with how mypy refers to it internally.

Co-authored-by: hauntsaninja <>
2020-10-25 21:31:43 +01:00
ShantanuGitHubhauntsaninja <>
2f1367332b stubtest unused: match stubtest version, add fix (#4705)
In #4696 I bumped stubtest to a commit that hasn't been released. We
should have these stubtest versions match. In
https://github.com/python/mypy/pull/9426 I changed the output of
stubtest here; it's good to get this change in before I forget and this
action silently stops working.

Co-authored-by: hauntsaninja <>
2020-10-25 11:19:15 +01:00
0583738a41 Add a mypy self test (#4337)
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
Co-authored-by: hauntsaninja <>
2020-10-24 17:58:04 -07:00
ShantanuGitHubhauntsaninja <>
74bb849789 update stubtest (#4696)
Co-authored-by: hauntsaninja <>
2020-10-22 11:09:39 -07:00
ShantanuGitHubhauntsaninja <>
86ca46fa0a mypy_primer: add to CI (#4629)
Co-authored-by: hauntsaninja <>
2020-10-12 14:41:51 -07:00
Sebastian RittauandGitHub 5b11606d16 CI: Update Python and mypy versions (#4656)
* Use 3.9 final instead of 3.9-dev
* Remove explicit Python versions from utility scripts
* Use mypy 0.390 for stubtests
2020-10-12 15:01:09 +02:00
Sebastian RittauandGitHub bf5651e7a6 Use GitHub Actions to run mypy (#4594) 2020-10-01 14:42:31 -07:00
Sebastian RittauandGitHub fae202e2a9 Run pytype and mypy self test using GitHub Actions (#4565) 2020-09-21 16:07:08 +02:00
Sebastian RittauandGitHub bfec448860 Use GH Actions for linters (#4528) 2020-09-11 12:05:53 -07:00
ShantanuGitHubhauntsaninja <>
e9becf1da6 py39: enable in CI (#4494)
Github Actions now supports prerelease builds
https://github.com/actions/setup-python/issues/20

Co-authored-by: hauntsaninja <>
2020-08-31 22:05:57 +02:00
f23ce60668 stubtest: fix on windows (#4455)
Co-authored-by: Akuli
2020-08-17 14:55:58 -07:00
Sebastian RittauandGitHub 18aab6df0f Fix type in yaml file (#4339) 2020-07-18 07:03:23 -07:00
Sebastian RittauandGitHub 6acf0ef5f2 Create a PR when there are unused stubtest whitelist entries (#4334) 2020-07-18 14:48:55 +02:00
Sebastian RittauandGitHub 03d8795403 Update unused stubtest whitelist action trigger (#4315)
Now runs weekly instead of daily, but also add the ability to trigger
manually.
2020-07-07 10:12:52 -07:00
Sebastian RittauandGitHub 32c638cc88 Run the unused stubtest check only on python/typeshed (#4240)
Without this check, it is run on daily on every personal fork.
2020-06-18 10:47:05 -07:00
Sebastian RittauandGitHub 68a7b9b178 Collate all stubtest runs into a single output (#4231) 2020-06-17 11:48:44 -07:00
Sebastian RittauandGitHub 53431cab1d Remove unused stubtest entries (#4225)
Rename job
2020-06-12 06:57:23 -07:00
Sebastian RittauandGitHub cf3b74a0bf Move stubtest CI to GitHub Actions (#4223)
This ensures that the Python version used matches the one used in the
scheduled extraneous stubtest whitelist check.

See also PR #4206.
2020-06-11 12:39:06 -07:00
Sebastian RittauandGitHub 3d84c52a4c Do not stop other checks if one check fails (#4205) 2020-06-08 07:25:52 -07:00
Sebastian RittauandGitHub d76ad4710e Find unused stubtest whitelist entries (#4157)
* Find unused stubtest whitelist entries

This is currently a GitHub workflow that runs daily and lists all unused
whitelist entries found by running stubtest against current Python
versions on Linux and Windows. The workflow run will succeed if there
are no such entries, and fail otherwise.

In a second step, this should collate the output of the various runs and
create a PR to remove the entries. In that case, the workflow should
probably only run weekly or even monthly to keep the noise down.

Cf. #3728
2020-06-03 14:37:38 +02:00