Commit Graph

16 Commits

Author SHA1 Message Date
Jelle Zijlstra
e20a36ada2 add to CONTRIBUTING (#1560)
Ask contributors to better explain their changes and link to documentation and code. These things generally make pull requests easier to review.
2017-08-21 13:26:00 -07:00
Guido van Rossum
350563223f Add Optional[] for all remaining cases of x: <type> = None (#1424)
* Final round of adding Optional[] to type of arguments with default = None
* Update Travis to use --no-implicit-optionals and clarify CONTRIBUTING.md
2017-06-21 10:50:21 -07:00
Ethan Smith
ac36193550 Add Gitter chat badge (#1399)
And update other gitter links.
2017-06-12 15:55:05 -07:00
Emily Morehouse
85d017d1e8 Documentation updates for testing information (#1293)
- Removes references to 'runtests.sh', as it has been removed
- Adds links from the contributing file to the readme - testing section
- Updates flake8 stats
2017-05-22 16:10:26 -07:00
Emily Morehouse
b6d08b81a3 #1286 Remove header comments from stubs (#1292)
- Updates documentation related to previously required comment headers.
- Removes all comment headers from stubs
- Occasionally included a header for stubs that were noted to be incomplete or contained todo's.
2017-05-22 15:14:15 -07:00
Emily Morehouse
b2deca8c83 Add description of how the directory structure targets Python versions. (#1288) 2017-05-22 12:03:53 -07:00
Jelle Zijlstra
093a16f398 allow PEP 526-style annotations in all stubs (#1285)
Mypy, pytype, and PyCharm now all allow variable annotations in stubs; I think we already have some.
2017-05-22 11:15:48 -07:00
Jelle Zijlstra
15b6ace1e7 Add to core dev guidelines (#1279)
From https://github.com/python/typeshed/pull/1266#issuecomment-302916761.
2017-05-22 06:34:37 -07:00
Guido van Rossum
24f5bc4a2a Explain the set of labels we actually use (#1226) 2017-04-30 10:46:44 -07:00
Guido van Rossum
de95aac022 Remind core devs to delete their branches (#1073) 2017-03-22 20:23:37 -07:00
Jelle Zijlstra
34575af8e4 Add core dev guidelines (#1058)
* Add core dev guidelines
* add link to "Squash and merge"
2017-03-21 08:36:00 -07:00
Łukasz Langa
86864dc824 Add Jelle to the team 2017-03-20 21:22:09 -07:00
Jelle Zijlstra
d04b9b204e Function bodies should be empty (#959)
I've seen some stubs like

```
class X:
    def __init__(self, x: str) -> None:
        self.x = x
        self.y = 0
```
I think this should be written instead as
```
class X:
    x: str
    y: int
    def __init__(self, x: str) -> None: ...
```
2017-03-10 15:35:34 -08:00
Łukasz Langa
598c1d5545 Expand CONTRIBUTING.md with information about sys.version_info checks (#853) 2017-01-20 11:41:44 -08:00
Łukasz Langa
05c6c66fa4 Improve CONTRIBUTING.md (#824)
1. Mentioned review requirement for core contributors.
2. Made stub coding style on par with requirements specified on
   the Mypy wiki (we can merge them now).
2017-01-11 17:55:14 -08:00
Łukasz Langa
08432484d5 CONTRIBUTING.md (#790)
Fixes #772.
2016-12-24 08:46:08 -08:00