Handle nil result in pull diagnostic handler (#5147)

- A stale or cancelled textDocument/diagnostic request can be answered
  with a nil result and no error, which is valid per the LSP
  specification. Guard against it so the handler does nothing rather
  than indexing the nil result.

lua/ale/lsp.lua

@@ -77,7 +77,7 @@ module.start = function(config)
         end,
         -- Handle pull model diagnostic data.
         ["textDocument/diagnostic"] = function(err, result, request, _)
-            if err == nil then
+            if err == nil and result ~= nil then
                 local diagnostics
 
                 if result.kind == "unchanged" then

test/lua/ale_lsp_start_spec.lua

@@ -444,4 +444,31 @@ describe("ale.lsp.start", function()
             },
         }, vim_fn_calls)
     end)
+
+    it("should ignore pull model diagnostics with a nil result", function()
+        lsp.start({name = "server:/code"})
+
+        eq(1, #start_calls)
+
+        local handlers = start_calls[1][1].handlers
+
+        eq("function", type(handlers["textDocument/diagnostic"]))
+
+        -- A stale request can be answered with a nil result and no error,
+        -- which is valid per the LSP specification. The handler should do
+        -- nothing rather than index the nil result.
+        handlers["textDocument/diagnostic"](
+            nil,
+            nil,
+            {
+                params = {
+                    textDocument = {
+                        uri = "file://code/foo.py",
+                    },
+                },
+            }
+        )
+
+        eq({}, vim_fn_calls)
+    end)
 end)