4 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Koichi Murase	30a8ef28cd	[bash] Fix infinite retry loop for completion setting without "-F func" (#4004)	2024-09-23 19:16:59 +09:00
Koichi Murase	1525768094	[man] Escape hyphens to prevent conversion to Unicode hyphens (#3885) ... ASCII hyphens (U+002D HYPHEN-MINUS) in the option names (e.g. -x and --extended) and the code examples in the man pages should be escaped as \- (e.g. \-x and \-\-extended) to prevent them being converted to Unicode hyphens in some environments. For example, in openSUSE Tumbleweed, the raw ASCII hyphens in the man-page sources are configured to be the Unicode hyphen (U+2010 HYPHEN). This makes it impossible to search the option name in the man page by e.g. /--extended[RET]. A problem also arises in copying and pasting option names and code examples from the man page. It appears to be the normal ASCII hyphens by appearance (in typical terminal fonts) but are not recognized as the ASCII hyphens by the `fzf` command.	2024-06-24 09:32:35 +09:00
Koichi Murase	01871ea383	[bash] Update orig_complete after _completion_loader	2024-03-10 21:41:42 +09:00
Koichi Murase	1dbdb9438f	[bash] Refactor access to "_fzf_orig_complete_${cmd//[^A-Za-z0-9_]/_}" ... In the current codebase, for the original completion settings, the pieces of the codes to determine the variable name and to access the stored data are scattered. In this patch, we define functions to access these variables. Those functions will be used in a coming patch. * This patch also resolves an inconsistent escaping of "$cmd": $cmd is escaped as ${...//[^A-Za-z0-9_]/_} in some places, but it is escaped as ${...//[^A-Za-z0-9_=]/_} in some other places. The latter leaves the character "=" in the command name, which causes an issue because "=" cannot be a part of a variable name. For example, the following test case produces an error message: $ COMP_WORDBREAKS=${COMP_WORDBREAKS//=} $ _test1() { COMPREPLY=(); } $ complete -vF _test1 cmd.v=1.0 $ _fzf_setup_completion path cmd.v=1.0 $ cmd.v=1.0 [TAB] bash: _fzf_orig_completion_cmd_v=1_0: invalid variable name The behavior of leaving "=" was present from the beginning when saving the original completion is introduced in commit 91401514, and this does not seem to be a specific reasoning. In this patch, we replace "=" as well as the other non-identifier characters. * Note: In this patch, the variable REPLY is used to return values from functions. This design is to make it useful with the value substitutions, a new Bash feature of the next release 5.3, which is taken from mksh.	2024-03-10 21:41:42 +09:00