Fix potential AttributeError in get_defintion_start_position/get_defintion_end_position, see #1584

This commit is contained in:
Dave Halter
2020-05-18 19:20:53 +02:00
parent 8fdf16b316
commit 855fb5a936

View File

@@ -238,6 +238,8 @@ class BaseName(object):
:rtype: Optional[Tuple[int, int]] :rtype: Optional[Tuple[int, int]]
""" """
if self._name.tree_name is None:
return None
definition = self._name.tree_name.get_definition() definition = self._name.tree_name.get_definition()
if definition is None: if definition is None:
return self._name.start_pos return self._name.start_pos
@@ -250,10 +252,10 @@ class BaseName(object):
:rtype: Optional[Tuple[int, int]] :rtype: Optional[Tuple[int, int]]
""" """
if self._name.tree_name is None:
return None
definition = self._name.tree_name.get_definition() definition = self._name.tree_name.get_definition()
if definition is None: if definition is None:
if self._name.tree_name is None:
return None
return self._name.tree_name.end_pos return self._name.tree_name.end_pos
if self.type in ("function", "class"): if self.type in ("function", "class"):
last_leaf = definition.get_last_leaf() last_leaf = definition.get_last_leaf()