Peter Law
dd60a8a4c9
Extract nested function which is going to be used elsewhere
2020-03-22 15:20:58 +00:00
Peter Law
5bd6a9c164
Rename function which is going to be used elsewhere
2020-03-22 15:18:41 +00:00
Peter Law
c743e5d9f3
Push type check into helper
2020-03-22 15:14:01 +00:00
Peter Law
5ca69458d4
Add testing for mismatch cases
...
This should help catch any errors in our handling of invalid cases.
While some of these produce outputs which aren't correct, what
we're checking here is that we don't _error_ while producing that
output.
Also fix a case which this showed up.
2020-03-22 15:10:43 +00:00
Peter Law
95b0cdcb5e
Add test for child of specialised generic
2020-03-18 22:15:32 +00:00
Peter Law
0f8e7b453e
Formatting
2020-03-18 22:12:21 +00:00
Peter Law
da9d312185
Remove redundant attribute check
2020-03-12 22:06:13 +00:00
Peter Law
b198434694
Remove resolved TODO
...
The common logic this refers to has now been extracted (see 95cec459 )
and the remaining checks are specific to tuple handling.
2020-03-07 20:29:14 +00:00
Peter Law
d06efd0dd1
Push fetching of generics into nested function
...
This slightly simplifies both the calling code and semantics of
the nested function.
2020-03-07 18:09:20 +00:00
Peter Law
96132587b7
Clarify generic tuple inference
...
This hoist a loop invariant conditional check outside the loop
making it clearer and one branch more obviously similar to the
general type handling.
2020-03-07 17:35:29 +00:00
Peter Law
5d273f4630
Explain these branches
2020-03-07 17:35:03 +00:00
Peter Law
95cec459a8
Extract nested function for common pattern
...
This slightly simplifies the code, as well as providing a place
to put an explanation of what the moved block of code does.
2020-03-07 17:06:22 +00:00
Peter Law
3b4fa2aa9c
Clarify variable name
2020-03-07 16:32:38 +00:00
Peter Law
54e29eede1
Add explanation of the parameters to _infer_type_vars
2020-03-07 16:31:12 +00:00
Peter Law
f1a9e681ad
Ensure comprehensions and generator expressions work
2020-02-23 15:25:28 +00:00
Peter Law
f4cbf61604
Ensure variadic tuples (Tuple[T, ...]) behave like sequences
2020-02-23 14:00:39 +00:00
Peter Law
5e990d9206
Support passing through values for non-annotated tuples
2020-02-23 14:00:16 +00:00
Peter Law
80db4dcf56
Add test to ensure unions work
2020-02-23 14:00:16 +00:00
Peter Law
e557129121
Remove check which doesn't seem to be needed
...
I'm not sure why I added this, though removing it doesn't seem to
casue any issues. I suspect there might be some oddness if the type
being passed in doesn't match the type expected, though them having
the same number of generic paramters isn't an expecially great way
to validate that.
2020-02-23 14:00:16 +00:00
Peter Law
c15e0ef9b8
Ensure specialised types inheriting from generics work
2020-02-23 14:00:15 +00:00
Peter Law
e455709a31
Add test case for nested generic callables
2020-02-23 14:00:13 +00:00
Peter Law
c03ae0315e
Make nested Type[T] annotations work
2020-02-23 13:59:44 +00:00
Peter Law
bc53dabce3
Make tuple generic parameters work
2020-02-23 13:59:44 +00:00
Peter Law
969a8f1fd9
First pass at extending infer_type_vars
...
This mostly works for the new tests, but doesn't work for:
- tuples (though this seems to be because they lack generic information anyway)
- nested Type[T] handling (e.g: List[Type[T]])
2020-02-23 13:59:44 +00:00
Peter Law
0a7820f6de
Add many test cases
...
While these definitely _ought_ to work on Python 2.7, the annotation
support there is very limited and as Python 2 is deprecated it
doesn't seem worth it.
2020-02-23 13:58:10 +00:00
Peter Law
6efafb348e
Extract the annotation name upfront
...
We almost always need this and this simplifies the code within
each branch. This also means we'll be able to the name to determine
the branching.
2020-02-22 19:42:08 +00:00
Peter Law
36b4b797c1
Add trailing comma
2020-02-22 19:42:08 +00:00
Peter Law
c4cf0d78e1
Add a couple of docstrings
...
These are based on observation of the outputs of these functions.
2020-02-15 12:25:12 +01:00
Peter Law
c7d1b8de9e
Tell sith that 'completions' became 'complete'
2020-02-13 09:51:31 +01:00
Peter Law
370e539a7e
Remove additional prefix which seems incorrect
2020-02-09 11:39:41 +01:00
Peter Law
fd1f9f22e9
Update use of _source which no longer exists to _code
2020-02-09 11:39:41 +01:00