Re-enable NQA102 (#9426)

re-enable NQA102
This commit is contained in:
Avasam
2023-01-02 18:49:02 -05:00
committed by GitHub
parent 4a7e14e5ad
commit c45999d905
2 changed files with 4 additions and 10 deletions

10
.flake8
View File

@@ -22,22 +22,18 @@
# Y037 Use PEP 604 syntax instead of `typing.Union` and `typing.Optional`.
# Currently can't be enabled due to a few lingering bugs in mypy regarding
# PEP 604 type aliases (see #4819).
# NQA102 "noqa" code has no matching violations. We often introduce "noqa" comments
# into the typeshed codebase to unblock flake8-pyi PRs, meaning these comments
# have "no matching violations" since the relevant flake8-pyi checks haven't
# yet been released.
[flake8]
per-file-ignores =
*.py: E203, E301, E302, E305, E501
*.pyi: B, E301, E302, E305, E501, E701, E741, NQA102, F401, F403, F405, F822, Y037
*.pyi: B, E301, E302, E305, E501, E701, E741, F401, F403, F405, F822, Y037
# Since typing.pyi defines "overload" this is not recognized by flake8 as typing.overload.
# Unfortunately, flake8 does not allow to "noqa" just a specific error inside the file itself.
# https://github.com/PyCQA/flake8/issues/1079
# F811 redefinition of unused '...'
stdlib/typing.pyi: B, E301, E302, E305, E501, E701, E741, NQA102, F401, F403, F405, F811, F822, Y037
stdlib/typing.pyi: B, E301, E302, E305, E501, E701, E741, F401, F403, F405, F811, F822, Y037
# Generated protobuf files include docstrings
*_pb2.pyi: B, E301, E302, E305, E501, E701, NQA102, Y021, Y026
*_pb2.pyi: B, E301, E302, E305, E501, E701, Y021, Y026
exclude = .venv*,.git
noqa_require_code = true

View File

@@ -99,9 +99,7 @@ class Display:
def check_for_error(self) -> None: ...
def send_request(self, request: rq.Request | rq.ReplyRequest | ConnectionSetupRequest, wait_for_response: bool) -> None: ...
def close_internal(self, whom: object) -> None: ...
def send_and_recv(
self, flush: bool = ..., event: bool = ..., request: int | None = ..., recv: bool = ... # noqa: F811
) -> None: ...
def send_and_recv(self, flush: bool = ..., event: bool = ..., request: int | None = ..., recv: bool = ...) -> None: ...
def parse_response(self, request: int) -> bool: ...
def parse_error_response(self, request: int) -> bool: ...
def default_error_handler(self, err: object) -> None: ...