attempt to get rid of TODOS, should i edit tests too?

This commit is contained in:
Filip Hron
2016-03-03 16:55:33 +01:00
parent 5b92f7cbc5
commit e7e50b6997
2 changed files with 4 additions and 8 deletions

View File

@@ -321,8 +321,7 @@ class socket:
... # return type: None on success
def sendto(self, data: str, address: Union[tuple, str], flags: int = ...) -> int: ...
def setblocking(self, flag: bool) -> None: ...
# TODO None valid for the value argument
def settimeout(self, value: float) -> None: ...
def settimeout(self, value: Union[float, None]) -> None: ...
def setsockopt(self, level: int, optname: str, value: Union[int, str]) -> None: ...
def shutdown(self, how: int) -> None: ...
@@ -359,6 +358,5 @@ def inet_aton(ip_string: str) -> str: ... # ret val 4 bytes in length
def inet_ntoa(packed_ip: str) -> str: ...
def inet_pton(address_family: int, ip_string: str) -> str: ...
def inet_ntop(address_family: int, packed_ip: str) -> str: ...
# TODO the timeout may be None
def getdefaulttimeout() -> float: ...
def getdefaulttimeout() -> Union[float, None]: ...
def setdefaulttimeout(timeout: float) -> None: ...

View File

@@ -320,8 +320,7 @@ class socket:
... # return type: None on success
def sendto(self, data: bytes, address: Union[tuple, str], flags: int = ...) -> int: ...
def setblocking(self, flag: bool) -> None: ...
# TODO None valid for the value argument
def settimeout(self, value: float) -> None: ...
def settimeout(self, value: Union[float, None]) -> None: ...
def setsockopt(self, level: int, optname: str, value: Union[int, bytes]) -> None: ...
def shutdown(self, how: int) -> None: ...
@@ -358,6 +357,5 @@ def inet_aton(ip_string: str) -> bytes: ... # ret val 4 bytes in length
def inet_ntoa(packed_ip: bytes) -> str: ...
def inet_pton(address_family: int, ip_string: str) -> bytes: ...
def inet_ntop(address_family: int, packed_ip: bytes) -> str: ...
# TODO the timeout may be None
def getdefaulttimeout() -> float: ...
def getdefaulttimeout() -> Union[float, None]: ...
def setdefaulttimeout(timeout: float) -> None: ...