VimPlug/typeshed
1
0
Fork 0
mirror of https://github.com/davidhalter/typeshed.git synced 2025-12-06 20:24:30 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix mistyped get_by_id class methods (#7120)

Browse Source 
The types for these class methods were mixed up. The async method
returned an optional `Model`, while the synchronous method returned a
`Future`. It's the other way around.

Fixes #7103
This commit is contained in:
Roman Joost
2022-02-03 09:59:02 +10:00
committed by GitHub
parent 26e8959279
commit fc60d02c3e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
stubs/google-cloud-ndb/google/cloud/ndb/model.pyi
View File

@@ -320,7 +320,7 @@ class Model(_NotEqualMixin, metaclass=MetaModel):
max_memcache_items: int | None = ...,
force_writes: bool | None = ...,
_options=...,
) -> tasklets_module.Future: ...
) -> Model | None: ...
@classmethod
def get_by_id_async(
cls: type[Model],
@@ -344,7 +344,7 @@ class Model(_NotEqualMixin, metaclass=MetaModel):
max_memcache_items: int | None = ...,
force_writes: bool | None = ...,
_options=...,
) -> Model | None: ...
) -> tasklets_module.Future: ...
@classmethod
def get_or_insert(
cls: type[Model],