VimPlug/typeshed
1
0
Fork 0
mirror of https://github.com/davidhalter/typeshed.git synced 2026-08-30 19:46:57 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,008 Commits 6 Branches 2 Tags
4ed19cdaf53e19048c8a7cc04d1b6a477e077aa3
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jelle Zijlstra 97f830030c Simplify WatchedFileHandler.__init__ (#3506) 
Fixes #3502
 2019-12-03 14:54:29 +01:00
Jelle Zijlstra d215f502c6 Improve warnings stubs (#3501) 
* merge 2and3 for _warnings

* move warn and warn_explicit into _warnings
 2019-12-03 14:33:37 +01:00
Jelle Zijlstra 1f0dc6ee05 timeout argument to urllib.request.urlopen is Optional (#3487) 
The docs (https://docs.python.org/3/library/urllib.request.html#urllib.request.urlopen) aren't very precise about this, but passing `None` seems to work in practice.
 2019-11-24 12:51:33 +01:00
Jelle Zijlstra a89f883878 stream argument to pprint.pprint is Optional (#3488) 
None is the default; see https://docs.python.org/3/library/pprint.html#pprint.PrettyPrinter
 2019-11-24 12:29:43 +01:00
Jelle Zijlstra cd5cd12a35 asyncio: fix windows stubs (#3424) 2019-10-30 08:13:32 -07:00
Jelle Zijlstra c38cf6736e Allow callables in _SourceObjectType (#3295) 
This is important because mypy doesn't generally think functions are compatible with `FunctionType`, so `inspect.getsource` on arbitrary functions is rejected by the current annotations.
 2019-10-03 00:52:21 +02:00
Jelle Zijlstra d05a9d3d83 Improve enums (#3168) 
I realized while working on srittau/type-stub-pep#64 that a
few things we do in existing enum definitions in typeshed are
problematic:

- Using "= ..." doesn't allow type checkers to correctly type the
  result of Enum.MEMBER.value. In fact, mypy at least infers
  .value to be "Ellipsis" if you do this.
- Properties on the enum values themselves, like HTTPStatus.phrase,
  should not be specified directly as attributes, because it makes
  type checkers think that the properties themselves are enum
  members.

I ended up doing a bit more cleanup to the signal module:
- Remove unnecessary ... initializers.
- Remove unnecessary _SIG = Signals alias.
- I don't have Windows to test, but the C code for _signal suggests
  that CTRL_C_EVENT and CTRL_BREAK events are not Signals, but just ints:
  https://github.com/python/cpython/blob/1dbd084f1f68d7293718b663df675cfbd0c65712/Modules/signalmodule.c#L1575
 2019-08-05 08:08:57 -07:00
Jelle Zijlstra b0c9fa4530 fix type of loop.sock_connect (#3073) 2019-06-21 17:31:51 +02:00
Jelle Zijlstra ada0570efc Revert "Define functools.partial as overloaded function instead of its own class (#2878)" (#3077) 
This reverts commit e45f443d85.
 2019-06-20 20:39:49 -07:00
Jelle Zijlstra cd9b7158ec fix CI (#2992) 2019-05-15 14:20:08 -07:00
Jelle Zijlstra b5493e8639 add types.FunctionType.__init__ (#2968) 
Fixes #2930
 2019-05-07 17:31:01 +02:00
Jelle Zijlstra d7e9af4492 allow callables in dis() (#2969) 
Fixes #2914
 2019-05-07 17:21:54 +02:00
Jelle Zijlstra bdb1de57f5 narrow signature of __contains__ for str-like classes (#2967) 
Fixes #2937
 2019-05-07 10:24:28 -04:00
Jelle Zijlstra 8bd744a38f fix type of msg argument to HTTPRedirectHandler.redirect_request (#2949) 
It's not really documented (https://docs.python.org/3/library/urllib.request.html#urllib.request.HTTPRedirectHandler.redirect_request), but logically a message is a str, and reading the code for the stdlib confirms that it's intended to be a str.
 2019-05-03 20:44:56 +02:00
Jelle Zijlstra ff650d3275 socket: add .set_inheritable() (#2935) 2019-04-28 17:13:20 +02:00
Jelle Zijlstra ce2b8a838c reword "What to include" (#2861) 2019-04-08 19:02:01 +02:00
Jelle Zijlstra 832bf52c28 asyncio: make type alias private and CamelCase (#2849) 2019-03-11 08:43:00 +01:00
Jelle Zijlstra 14e387b6fd fix some minor lint errors (#2820) 
Caught by a newer version of flake8
 2019-03-01 12:29:23 +01:00
Jelle Zijlstra b5897d5643 fix undefined name in flask stub (#2811) 2019-02-23 10:28:03 +01:00
Jelle Zijlstra 2aee28cb6f fix missing space in imghdr (#2812) 2019-02-23 10:26:51 +01:00
Jelle Zijlstra 78690405cf add back StopIteration.value in Python 3 (#2744) 
Fixes python/mypy#6209.
 2019-01-16 19:21:16 -08:00
Jelle Zijlstra 46ab77eb20 loop argument to asyncio.ensure_future is Optional (#2708) 
The default value is None: https://github.com/python/cpython/blob/master/Lib/asyncio/tasks.py#L616.
 2018-12-20 15:24:03 -08:00
Jelle Zijlstra 1a42a2c3ea fix list concatenation (#2404) 
Fixes #2383, python/mypy#5492.
 2018-11-08 06:42:57 -08:00
Jelle Zijlstra 63cf7f529b fix lint error (#2541) 2018-10-23 14:00:26 +02:00
Jelle Zijlstra bc3f9fe1d3 fix typing.Pattern in Python 2 (#2219) 
Fixes #2199
 2018-10-01 20:35:13 -07:00
Jelle Zijlstra 1bc1fc2117 add constructor arguments for TimeoutExpired (#2466) 
Previously, constructing a TimeoutExpired directly worked because Exception allowed arbitrary kwargs. We fixed that recently, but now mypy gives an error on creating a TimeoutExpired with legal arguments.
 2018-09-18 14:02:38 +02:00
Jelle Zijlstra 8b9e4c378a fix module argument to unittest.main (#2403) 2018-09-10 11:04:05 -07:00
Jelle Zijlstra 9d62d6d5c5 fix __metaclass_ references (#2402) 2018-09-06 18:24:03 -07:00
Jelle Zijlstra 2e1c81684e fix duplicate definitions in tornado (#2424) 
Fixes #2423.

I followed https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py and kept the `@property` where it exists in the implementation and the attribute where it doesn't.
 2018-09-03 16:39:51 -07:00
Jelle Zijlstra 6f62466d6f fix selftest (#2425) 
Now that the typeshed submodule has moved.
 2018-09-03 10:35:20 -07:00
Jelle Zijlstra 761b620e1a add @srittau to maintainers (#2420) 2018-08-28 16:50:50 +02:00
Jelle Zijlstra 9e023e7586 minor namedtuple fixes (#2227) 
- The extra arguments aren't keyword-only in 2.7.
- Added the `defaults` argument in 3.7 (https://docs.python.org/3.7/library/collections.html#collections.namedtuple).
 2018-08-19 03:47:10 +01:00
Jelle Zijlstra fd6f99ca2c fix mypy-selftest (#2341) 2018-07-18 21:12:37 -07:00
Jelle Zijlstra 574807d9ea os.get_terminal_size also exists on Windows (#2338) 
... at least according to https://docs.python.org/3/library/os.html#os.get_terminal_size.

Related to python/mypy#5370.
 2018-07-18 10:25:12 -07:00
Jelle Zijlstra 7d3ec1e0be Improvements to pymysql (#2220) 
* don't use type comments

* split up long lines

* all the constants are ints

* fixes to pymysql stub

* drop __all__, fix tabs
 2018-07-13 19:43:09 -07:00
Jelle Zijlstra fc290167eb Fixes to boto.s3.key stub (#2317) 
* replace type comments in key.pyi

* reformat the file with black

* get_contents_as_string returns bytes unless an encoding is specified

http://boto.cloudhackers.com/en/latest/ref/s3.html#boto.s3.key.Key.get_contents_as_string
 2018-07-13 19:39:24 -07:00
Jelle Zijlstra 00cda79cf5 add io.TextIOWrapper.read in 3.3 (#2248) 
This is needed to make TextIOWrapper and a few classes that inherit
from it concrete in 3.3. I am actually not sure whether this method
exists at runtime; there's nothing in
https://docs.python.org/3/library/io.html#io.TextIOWrapper
that suggests it was added in 3.4. In any case, it hardly matters
since 3.3 usage should be very rare now.
 2018-06-17 23:47:07 +01:00
Jelle Zijlstra 3032fbdff1 make http.client.HTTPResponse concrete in 3.4 (#2244) 
Matches the implementation in https://github.com/python/cpython/blob/3.4/Lib/http/client.py#L308

The ignore works around python/mypy#5027 (commented further up in the 3.5 branch).

Part of #1476.
 2018-06-17 17:29:02 +01:00
Jelle Zijlstra da8de48f6d UserList and UserString in 2.7 (#2246) 
Fill out UserList and UserString stubs to make the classes concrete. Compare:
https://github.com/python/cpython/blob/2.7/Lib/UserList.py
https://github.com/python/cpython/blob/2.7/Lib/UserString.py
 2018-06-17 17:24:30 +01:00
Jelle Zijlstra 8084dc1c1f Fix abstract classes in 2.7 (#2247) 
Part of #1476.
 2018-06-17 17:21:17 +01:00
Jelle Zijlstra 6b36b1befe Iterator provides a concrete __iter__ in 2.7 (#2245) 
This is already how it works in the Python 3 stub.

`Iterator.__iter__` also exists at runtime: https://github.com/python/cpython/blob/2.7/Lib/_abcoll.py#L73.
 2018-06-17 12:00:42 +01:00
Jelle Zijlstra 0393de4bd7 fix some abstract classes in Python 2 (#2240) 
Part of #1476.
 2018-06-17 00:56:00 +01:00
Jelle Zijlstra 94ab32ba59 Fix abstract classes for Python 3 (#2239) 
* add metaclass=ABCMeta to some classes

* mark some more classes as explicitly abstract

* make some more classes concrete
 2018-06-16 10:18:54 -07:00
Jelle Zijlstra 341fa375ef cleanup in typing.pyi (#2241) 
- Fix TODOs around TracebackType
- Don't use quotes for forward references
- Make Generator and AsyncGenerator attributes into properties
 2018-06-16 08:24:52 -07:00
Jelle Zijlstra c06a718c5b always run mypy with --no-implicit-optional (#2242) 
This was already the configuration in Travis and it's been working fine. It's
confusing that Travis was using a different configuration than the default
when you run tests/mypy_test.py yourself.
 2018-06-15 21:34:14 -07:00
Jelle Zijlstra 499f852e37 add --show-traceback to mypy_test.py flags (#2236) 
This makes debugging easier.
 2018-06-15 16:46:59 -07:00
Jelle Zijlstra de86f15fa0 Make http.client.HTTPResponse a BinaryIO (#2218) 
Fixes #2189.

The errors from mypy are a false positive (see python/mypy#5027).
 2018-06-12 09:20:24 -07:00
Jelle Zijlstra 6bbf3d89eb Further improve codecs stubs (#2217) 
- remove header comments
- uppercase type aliases
- remove old-style type annotations
- unquote forward refs
- reformat the file
- remove values for globals
- don't use private names from codecs stub in io.pyi
 2018-06-11 22:24:34 -07:00
Jelle Zijlstra bdb06b5b81 improve codecs stubs (#2114) 
Started out as progress towards #1476, but I ended up fixing a few more things:
- fixed the signature of _encode_type, which actually returns a pair, not a string
- made some attributes into properties in order to prevent the descriptor protocol from turning them into methods
- found a bug in CPython in the process (python/cpython#6779)

I used the following test file to make sure these classes are now instantiable:

```python
import codecs
import io
from typing import IO

bio = io.BytesIO()
cod = codecs.lookup('utf-8')

codecs.StreamReaderWriter(bio, codecs.StreamReader, codecs.StreamWriter)
codecs.StreamRecoder(bio, cod.encode, cod.decode, codecs.StreamReader, codecs.StreamWriter)
```
 2018-06-11 15:53:15 -07:00
Jelle Zijlstra d2469c0e89 fix type for itertools.product (#2129) 
Fixes #1850.

The fix was already applied to Python 2, but the typevar-based solution there
leads to "cannot infer value of type variable" in mypy. I used the following
script to check:

```python
from itertools import product

reveal_type(product([1]))
reveal_type(product([1], ['x'], [False], [3.0], [(1,)], [('x',)], [{1}], [{1: 2}], repeat=5))
```
 2018-06-11 15:52:44 -07:00
Jelle Zijlstra ced5d61bb6 make urllib.response.addinfourl instantiable (#2134) 
Fixes #1377 (because HTTPError is a subclass of addinfourl). Also part of #1476.
 2018-06-11 15:43:53 -07:00
Jelle Zijlstra 4e6af84640 improve multiprocessing.Pool types (#2126) 
Fixes #1703

Mostly introduce typevars to express that the return types match the return types of the
callbacks.

Removed comment about incompleteness since all documented classes from
https://docs.python.org/3/library/multiprocessing.html#module-multiprocessing.pool
are covered.
 2018-06-11 14:42:57 -07:00
Jelle Zijlstra 82c930e66c Improve asyncio.tasks stubs (#2139) 
- Use PEP 526-style variable annotations where possible
- Use FrameType instead of Any
- Remove workaround for mypy issue that was since fixed
 2018-06-11 14:40:54 -07:00
Jelle Zijlstra f5a74fd5da remove Optional from type of __slots__ (#2128) 
Fixes #1853
 2018-06-11 14:29:11 -07:00
Jelle Zijlstra f65caed181 allow socket.recv_into to take a memoryview (#2127) 
Fixes #1862
 2018-06-11 14:25:11 -07:00
Jelle Zijlstra cb293ebd2e switch order of base classes on awaitable classes (#2125) 
Fixes #1940.

This makes it so that mypy will infer the common base class of these
classes to be Awaitable instead of Iterable. I verified that this
fixes the errors in the script posted by @neilconway.
 2018-06-11 14:20:31 -07:00
Jelle Zijlstra 7abcd0f71f add ConfigParser.readfp in Python 3 (#2123) 
https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.readfp

Fixes #2112
 2018-06-11 14:10:52 -07:00
Jelle Zijlstra 53fde2ddf7 make timeout argument to Connection.poll Optional (#2122) 
Fixes #2094
 2018-06-11 14:04:45 -07:00
Jelle Zijlstra 91af6291b1 make shlex.shlex and multiprocessing.pool.IMapIterator instantiable (#2120) 
Part of #1476.
 2018-06-11 14:04:05 -07:00
Jelle Zijlstra c5bc3bd7fa make contextvars.Context instantiable (#2119) 
Part of #1476.
 2018-06-11 14:03:02 -07:00
Jelle Zijlstra f789ee25ad make EnumMeta instantiable (#2118) 
part of #1476. Verified that len(Enum) is still allowed by mypy.
 2018-06-11 14:02:16 -07:00
Jelle Zijlstra f73351f5bf make tracemalloc.Traceback instantiable (#2117) 2018-06-11 14:01:46 -07:00
Jelle Zijlstra 28f6c095d4 make http.cookies.{Base,Simple}Cookie instantiable (#2116) 
Part of #1476.
 2018-06-11 14:01:17 -07:00
Jelle Zijlstra a33a124537 make BZ2File and LZMAFile instantiable (#2115) 
Part of #1476.
 2018-06-11 13:59:38 -07:00
Jelle Zijlstra 764ee4eeec add pytz.ZERO and pytz.HOUR (#2180) 
https://github.com/stub42/pytz/blob/master/src/pytz/__init__.py#L187
 2018-06-11 11:27:34 -07:00
Jelle Zijlstra 38fb53eab6 add __init__ to SimpleNamespace (#2207) 
```In [11]: SimpleNamespace(x=3)
Out[11]: namespace(x=3)
```
 2018-06-11 08:08:41 -07:00
Jelle Zijlstra cd4a5ff65c use pytype-single rather than pytype (#2198) 
Looks like this happened in https://github.com/google/pytype/commit/3de774361b2481b55ef493391429e88571f7b9f2.
 2018-06-05 08:34:21 -07:00
Jelle Zijlstra eef0b1d562 fix type for TestCase.assertIn (#2186) 
* fix type for TestCase.assertIn

This does essentially `assert member in container`, so we want a `Container`, not an `Iterable`.

This came up in https://github.com/ambv/black/pull/288/files/68e9d426a86edc187a3f58ea889a2002620f0de6..0bbee43d60dfc16d8bbdd0bbdaad754a2c8c7ec0#r192525658.

* use any for assertIn
 2018-06-04 15:34:09 -07:00
Jelle Zijlstra da7b04904c Limit lines to 130 chracters (#2169) 
Fixes #2124.

As mentioned in the issue, the current guidelines lead to extremely long lines of many hundreds of characters, which make code hard to read and review. I think there should be some limit to line length, but it's OK for stubs to have somewhat longer lines than normal code.

For reference, there are currently 115 lines in typeshed over 200 characters; 523 over 120 characters; and 2980 over 79 characters.

We picked 130 because that's the longest line GitHub displays on a 13" laptop in a unified diff without folding. There are currently 382 lines in typeshed that are over 130 characters.
 2018-05-29 08:28:08 -07:00
Jelle Zijlstra b89f9553e9 keep os.path in 2 and 3 consistent (#2152) 
We can't merge these because os/__init__ is still different.

Also slight refactor of tests/check_consistent.py to avoid `from os import path`.
 2018-05-22 07:14:13 -07:00
Jelle Zijlstra 537b97ed39 add bytearray.copy to Python 3 (#2133) 
Fixes #1715.

2.7's bytearray doesn't have it.
 2018-05-15 14:33:24 -04:00
Jelle Zijlstra 55be42f6d6 add __fspath__ support to os.path (#2053) 
Fixes #1997, #2068.

This is tricky because we need to get the return values right (see #1960 for
prior attempts) and we often run into python/mypy#3644. I found that I
could express most signatures correctly using a series of overloads.

A few other changes in here:
- Added splitunc, which according to https://docs.python.org/3/library/os.path.html
  should exist in both Unix and Windows.
- Made the second argument to os.path.curdir Optional to match the implementation.
- Fixed os.path.split, whose previous Path-aware signature triggered python/mypy#3644.
 2018-05-15 10:31:40 -04:00
Jelle Zijlstra 463b4144dc explicitly import boto.regioninfo (#2121) 
This may be causing intermittent test failures (see discussion on gitter).
 2018-05-15 10:09:44 -04:00
Jelle Zijlstra fc9a822348 specify what type Binary is (#2057) 
Fixes python/mypy#4916.
 2018-04-27 14:40:33 -07:00
Jelle Zijlstra 46f0bb8b91 support unicode in Python 2 for difflib (#2055) 
Fixes #1961.

I mostly just replaced all str annotations with Text, including in return types. This is
only broadly correct; diffing a str and a unicode sequence actually results in a mixed
output of str and unicode. We could also keep the return types as str if using Text
causes errors in real code. For callbacks that take str, I introduced a Union alias
because a callable taking a str would not be a compatible with a parameter of type
Callable[[Text], bool].

I also fixed the return type of difflib.restore.
 2018-04-27 14:39:18 -07:00
Jelle Zijlstra f60ffe47a2 add attributes to locale (#2056) 
Fixes #1888.
 2018-04-27 14:38:22 -07:00
Jelle Zijlstra c7e3e9890d add UserDict.__init__ for Python 3 (#2083) 
Fixes #2075
 2018-04-27 14:38:00 -07:00
Jelle Zijlstra 9e25506cab add missing attributes to Python 2 unicode errors (#2084) 2018-04-27 14:37:20 -07:00
Jelle Zijlstra 5554b0b19b argparse.ArgumentParser.error never returns (#2082) 
And neither does `.exit`.

Fixes #2081.
 2018-04-25 21:30:31 -07:00
Jelle Zijlstra a5429d25dc add missing methods to DictMixin (#2054) 
Fixes #1896.
 2018-04-14 14:21:07 -07:00
Jelle Zijlstra b1a0b8ad6e add subprocess.STARTUPINFO and some associated constants (#2041) 2018-04-12 12:29:42 -07:00
Jelle Zijlstra 0f425db197 fix types for unittest.TestLoader.loadTestsFrom* methods (#2042) 
Fixes #2008.
 2018-04-12 12:29:32 -07:00
Jelle Zijlstra 37aba00fe8 fix using ZipFile as a ContextManager (#2043) 2018-04-12 12:29:22 -07:00
Jelle Zijlstra b8b78886e3 add some Optionals to traceback.pyi (#2044) 
Fixes #1974
 2018-04-12 12:29:07 -07:00
Jelle Zijlstra 840f34147e add a lot more distutils.errors (#2045) 
Fixes #1963.

See https://github.com/python/cpython/blob/2.7/Lib/distutils/errors.py and https://github.com/python/cpython/blob/3.7/Lib/distutils/errors.py.
 2018-04-12 12:28:55 -07:00
Jelle Zijlstra 7cd2016931 add sys.base_exec_prefix and sys.base_prefix (#2047) 
See https://docs.python.org/3/library/sys.html#sys.base_exec_prefix.

Required for https://github.com/python/mypy/pull/4888
 2018-04-11 13:59:44 -07:00
Jelle Zijlstra db989427cb dest argument to add_argument is Optional (#2040) 
argparse.py checks for None in _get_optional_kwargs.
 2018-04-10 21:47:30 -07:00
Jelle Zijlstra bdea1bb292 fix third_party/2/enum.pyi (#2039) 
This fixes an error in Travis that seems to have been caused by python/mypy#4319.

The fix was taken from the stdlib/3.4/enum.pyi stub. Mypy no longer assumes
that classes whose metaclass is EnumMeta are subclasses of Enum, so we can't
bound the typevar on Enum.
 2018-04-10 21:34:59 -07:00
Jelle Zijlstra 81a6ea43a5 try using --no-site-packages (#2036) 
Fixes #2035.
 2018-04-09 12:55:18 -07:00
Jelle Zijlstra f37709f9c3 Merge stubs for sqlite3 (#2026) 
As promised in #2014.

There are virtually no real changes between Python 2 and 3 in this module, but the stub had accumulated some meaningless differences. I also fixed a few incorrect types.
 2018-04-09 12:32:59 -07:00
Jelle Zijlstra 3f456e335e add multiprocessing.Process.kill and close (#2027) 
See https://docs.python.org/3.7/library/multiprocessing.html#multiprocessing.Process.kill.

Fixes #2022.
 2018-04-09 12:04:14 -07:00
Jelle Zijlstra d43eac60dd add email.parser.FeedParser (#2028) 
Fixes #1985.
 2018-04-09 12:03:43 -07:00
Jelle Zijlstra 6862434eae fix return type for itsdangerous.Signer.unsign (#2029) 
Fixes #2011

Also fixed the argument type (it doesn't accept str).
 2018-04-09 12:00:41 -07:00
Jelle Zijlstra 8482b1030b fill out stubs for requests.structures (#1897) 
Looked at https://github.com/requests/requests/blob/master/requests/structures.py.

The "data" argument to the CaseInsensitiveDict constructor is passed as is to .update(),
so I accept the same argument types as MutableMapping.update.

LookupDict is strangely named and implemented but the point seems to be that you
setattr its keys, and then can access them with both attribute access and subscripting.
See its usage in https://github.com/requests/requests/blob/d1fb1a29ab949223d8d64797e0fcc9a7d2690483/requests/status_codes.py#L102.
 2018-04-06 11:36:43 -07:00
Jelle Zijlstra 482f207b3c os.fwalk supports bytes (#2013) 
python/cpython@8f6b344 and https://bugs.python.org/issue28682.

I could not use the _PathLike alias because that includes bytes.

Part of #1965.
 2018-04-06 11:22:15 -07:00
Jelle Zijlstra d24799fd31 uncomment a few parts of six.moves (#2019) 2018-04-06 11:20:14 -07:00
Jelle Zijlstra 4ab720161a ResourceWarning doesn't exist in Python 2 (#2020) 
Fixes #1971.
 2018-04-06 11:19:34 -07:00
Jelle Zijlstra 54ecefef04 removals in Python 3.7 (#2018) 
Last part of #1965.
 2018-04-06 11:11:29 -07:00
Jelle Zijlstra 0acdfd1548 more 3.7 features (#2017) 2018-04-06 11:09:45 -07:00
Jelle Zijlstra 7cfbc7d17f more 3.7 features (#2015) 2018-04-06 11:09:11 -07:00