Commit Graph
100 Commits
Author SHA1 Message Date
Sebastian Rittau 4ac3ccad45 black: enable skip_magic_trailing_comma (#5252)
* black: enable skip_magic_trailing_comma

* Remove spurious commas
2021-04-27 08:32:32 -07:00
Sebastian Rittau f1cd416dcf Allow comments workflow appropriate permission (#5258) 2021-04-27 00:58:56 -07:00
Sebastian Rittau 7ca219f9c4 Add permissions to all workflows (#5255) 2021-04-26 16:51:35 +02:00
Sebastian Rittau 45916045c8 Upgrade black to 21.4b0 and reformat (#5250)
This introduces newlines before decorators.
2021-04-26 13:58:27 +02:00
Sebastian Rittau 48b060cfa0 mypy self check: Use mypy version from requirements file (#5245) 2021-04-26 12:51:28 +02:00
Sebastian Rittau bac1918b5f PathLike cleanup (#5242)
Copy builtins._PathLike to os.PathLike

Use os.PathLike exclusively outside of builtins
2021-04-23 10:15:07 -07:00
Sebastian Rittau f527e96dc3 Remove docutils.nodes.reference, which has no resemblance to the implementation (#5235) 2021-04-20 14:59:39 +02:00
Sebastian Rittau 4d734e38dd Add docutils definitions and (incomplete) modules (#5192) 2021-04-16 11:50:23 -07:00
Sebastian Rittau ba0f2b929b Always generate a comment for mypy_primer (#5197)
This way, runs without output after runs with output can be clearly
determined. This also makes it easier to recognize when a run was not
completed.
2021-04-15 09:18:13 +02:00
Sebastian RittauandJelle Zijlstra 190e07236f Tighten ensure_future() return type using overloads (#5190)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
2021-04-08 17:31:45 +02:00
Sebastian Rittau 2b9cd1e342 Suggest splitting Python 2 stubs (#5189)
Closes: #5049
2021-04-08 14:40:46 +02:00
Sebastian Rittau 9fbcc6cf95 Use protocols for gzip and _compression (#5170)
Closes: #5099
2021-04-07 20:06:19 -07:00
Sebastian RittauandAkuli 1906b98a4f Add @Akuli as maintainer (#5156)
* Add @Akuli as maintainer

Co-authored-by: Akuli <akuviljanen17@gmail.com>
2021-03-30 19:36:21 +03:00
Sebastian Rittau 5f52e38fdd Use SupportsWrite instead of IO (#5069) 2021-03-22 19:46:45 -07:00
Sebastian Rittau 29061d36ae Fix dict type if constructing with kwargs (#4987)
Closes #4846
2021-03-22 19:30:01 -07:00
Sebastian Rittau 0cea325bc7 Modernize logging (#5068) 2021-03-22 19:26:43 -07:00
Sebastian Rittau 2b19c761ec Fix build (#5086)
Run the mypy test suite using Ubuntu 18.04. Ubuntu 20.04 doesn't have a package for virtualenv on Python 2.

Also, curses.color_pair() now has a named argument.
2021-03-04 17:11:37 +01:00
Sebastian Rittau 08b26b9e8e Split and restore correct Python 2 version of cgi.pyi (#5064)
* Split cgi.pyi into Py2 and 3 versions

* Restore correct Python 2 version of cgi.pyi

* Remove unnecessary version checks in cgi.pyi

* Use collections.abc

* Use List in Python 2 stub
2021-02-24 14:46:03 -08:00
Sebastian Rittau c152e050f5 Fix stubtest errors (#5063)
A security fix added a "separator" argument to several URL parsing
functions and method in point releases:

* 3.6.13
* 3.7.10
* 3.8.8
* 3.9.2

Until all these versions are available on the GitHub Actions runners,
we need to whitelist the functions in the stubtests.
2021-02-24 14:37:38 +01:00
Sebastian Rittau c21329b68a Recommend using PEP 585 (#5055)
* Remove conventions enforced by black

Remove old note about optional default arguments (now part of
PEP 484 and enforced by CI)

* Recommend to use PEP 585

Cf. #4820

* Try out using collections.abc

* Reference mypy bug
2021-02-23 16:41:31 -08:00
Sebastian Rittau c8df617726 Use built-in generic (#5050) 2021-02-23 10:04:51 +01:00
Sebastian Rittau cf81a6df34 Remove unnecessary overloads from _patch.__init__() (#4824)
None of the arguments to __init__() are optional, so leaving out "new"
is not possible.
2021-01-24 14:29:38 +01:00
Sebastian Rittau 5961fe4aa8 Allow arguments to (memoryview,bytearray).hex (#4883)
Closes #4798
2021-01-01 15:00:03 -08:00
Sebastian Rittau 91582e6921 Drop old branches in stdlib/3/os/path.pyi (#4878)
* Drop support for Python 3.5 in stdlib/3/os/path.pyi

* Remove more obsolete branches
2020-12-30 12:41:09 -08:00
Sebastian Rittau 1c6ac09b82 Add EllipsisType, NoneType, and NotImplementedType (Python 3.10) (#4822) 2020-12-14 18:38:35 +01:00
Sebastian Rittau c26b804055 Remove a missing import (#4821)
Works around #4815, although a proper fix is needed.
2020-12-14 11:49:22 +01:00
Sebastian Rittau d2a7889fe0 Drop support for Python 3.5 (#4675)
Python 3.5 EOL was on 2020-09-30.
2020-11-02 16:18:20 +01:00
Sebastian Rittau cdc4de1af4 Derive Reversible from Iterable (#4622)
Closes: #4615
2020-11-01 13:17:41 -08:00
Sebastian Rittau 8aa3346a9c Remove some TODOs from IO classes (#4654)
At this point, it is too late to add methods to these semi-protocols as
it would break lots of existing code. Additionally, we are moving away
from these classes to finer-grained protocols anyway.
2020-11-01 13:11:19 -08:00
Sebastian Rittau c5aca0d533 Only add a mypy_primer comment if there is output (#4725) 2020-10-28 20:07:12 +01:00
Sebastian Rittau 4603728a15 Clean up files with former forced consistency (#4717)
Replace Text with str in Python 3 code
2020-10-27 07:52:35 +01:00
0583738a41 Add a mypy self test (#4337)
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
Co-authored-by: hauntsaninja <>
2020-10-24 17:58:04 -07:00
Sebastian Rittau 3de732e188 Split distutils for Python 2 and 3 (#4685)
Addresses #4679, but also starts addressing #4674.
2020-10-22 19:24:17 -07:00
Sebastian Rittau 5927e5ca30 Remove most consistency checks and split builtins.pyi into py2/3 files (#4686)
Split builtins.pyi in Python 2 and 3 versions

Partly addresses #4674
2020-10-22 13:39:06 -07:00
Sebastian Rittau 5b11606d16 CI: Update Python and mypy versions (#4656)
* Use 3.9 final instead of 3.9-dev
* Remove explicit Python versions from utility scripts
* Use mypy 0.390 for stubtests
2020-10-12 15:01:09 +02:00
Sebastian Rittau 473044cf1f Add information about removing third-party packages (#4637)
Closes: #4608
2020-10-09 16:27:56 +02:00
Sebastian Rittau 35f4ade96f Replace bool.__init__() with __new__() (#4614)
Fixes #4612
2020-10-09 00:20:03 +02:00
Sebastian Rittau 2157c4a448 Fix patch() used as decorator (#4592)
Closes: #4591
2020-10-02 09:05:25 +02:00
Sebastian Rittau bf5651e7a6 Use GitHub Actions to run mypy (#4594) 2020-10-01 14:42:31 -07:00
Sebastian Rittau 27dfbf68aa Use __new__ instead of __init__ for some builtin classes (#4555)
Closes #4514 #2630 #2686
2020-09-30 00:00:06 -07:00
Sebastian Rittau 0cd7dd7009 Fix _patch.__call__() (#4568)
_patch.call() reused the type variable _T, which is generic over
_patch. It was meant to use a separate type variable for the argument,
which is returned.

Fixes #4566
2020-09-23 14:35:19 -07:00
Sebastian Rittau 3d3dee91a3 Use overloads for Redis.sort() (#4551) 2020-09-21 20:54:46 +02:00
Sebastian Rittau fae202e2a9 Run pytype and mypy self test using GitHub Actions (#4565) 2020-09-21 16:07:08 +02:00
Sebastian Rittau f14d6eaa89 Improve unittest.mock.patch() types (#4277) 2020-09-21 15:26:39 +02:00
Sebastian Rittau 5d467a7756 Add more constants and attributes to posix (#4552)
The constants were found by running dir(posix) on a Debian 10.5 (x86_64)
system.

Resolves #616.
2020-09-19 23:19:36 -07:00
Sebastian Rittau 9a6b500909 Add various missing undocumented functions (#4554)
Mostly addresses #2149
2020-09-19 22:59:35 -07:00
Sebastian Rittau fe69ffcb0f Add a few missing stdlib modules (#4550) 2020-09-18 11:28:25 -04:00
Sebastian Rittau 4e88557666 Complete msvcrt (#4548) 2020-09-18 09:20:26 -04:00
Sebastian Rittau 4e2e02b266 Fix cls argument name of CodecInfo.__new__() (#4549) 2020-09-17 12:04:54 -07:00
Sebastian Rittau d4191de79f Upgrade pytype (#4540)
The latest version recognizes the @runtime_checkable
decorator, required for #4442.
2020-09-15 12:51:22 +02:00
Sebastian Rittau bfec448860 Use GH Actions for linters (#4528) 2020-09-11 12:05:53 -07:00
Sebastian Rittau 3c20675813 Remove pytest_mock (#4478)
pytest-mock is now type annotated, which makes typeshed's annotations
obsolete. See pytest-dev/pytest-mock#152.
2020-08-29 14:47:34 -07:00
Sebastian Rittau 4233008b4a TypeVar(bound) accepts strings for forward references (#4410) 2020-08-07 08:31:31 -07:00
Sebastian Rittau dc0bfc5889 Make FeedParser generic over Message (#4375) 2020-08-04 09:32:38 -07:00
Sebastian Rittau 7ed8c5f1da Add select.epoll.register to stubtest whitelist (#4376)
Python 3.8.5 changed the docstring slightly, possibly
a problem in stubtest.
2020-07-30 19:29:34 +02:00
Sebastian Rittau 36356b3368 Remove argument from deque.pop() (#4367)
Closes: #4364
2020-07-27 06:49:56 -07:00
Sebastian Rittau 06f87e5c92 Simplify pathlib (#4357)
* Enable some branches for Python2 pathlib2
* Define an alias _PathLike, instead of using multiple branches
* Drop a Python 3.4 branch (the Python 2 branch is identical to
  the 3.5+ branch)
* Move Path.__new__ to the top
2020-07-27 06:08:09 -07:00
Sebastian Rittau cfd06e2d3c Enable aliases in pytest_mock (#4359)
* Require newer pytype
2020-07-25 12:13:00 -07:00
Sebastian Rittau 18aab6df0f Fix type in yaml file (#4339) 2020-07-18 07:03:23 -07:00
Sebastian Rittau 6acf0ef5f2 Create a PR when there are unused stubtest whitelist entries (#4334) 2020-07-18 14:48:55 +02:00
Sebastian Rittau ee77a359eb Use 'black' profile for isort (#4336) 2020-07-17 07:20:48 -07:00
Sebastian Rittau 5e76f51930 Upgrade to isort 5 (#4323)
This now also reformats imports not at the top of files.
2020-07-16 07:01:57 -07:00
Sebastian Rittau 9ad8ed3b75 Introduce Mapping-like protocols (#4325)
typing.Mapping is not a protocol, which has caused problems in the past.
(E.g. python/typeshed#3569, see also python/typeshed#3576.) This
introduces a few narrow protocols to _typeshed.pyi that can be used in
place of Mapping.

Not all uses of Mapping can be replaced. For example, cgi.FieldStorage
explictly checks whether the supplied headers argument is a Mapping
instance.
2020-07-11 17:11:08 -07:00
Sebastian Rittau 209b6bb127 Remove tornado stubs (#4321)
Current tornado releases feature inline annotations and ship with
a py.typed file.
2020-07-09 07:20:11 -07:00
Sebastian Rittau 03d8795403 Update unused stubtest whitelist action trigger (#4315)
Now runs weekly instead of daily, but also add the ability to trigger
manually.
2020-07-07 10:12:52 -07:00
Sebastian Rittau b8f6d5fc54 Replace a few instances of IO with protocols (#4296) 2020-06-30 18:05:30 -07:00
Sebastian RittauandPhilipp Hahn 6bffc6534b Add nmap type information (#4292)
Author: Philipp Hahn <hahn@univention.de>

Co-authored-by: Philipp Hahn <hahn@univention.de>
2020-06-29 18:52:41 +02:00
Sebastian RittauandJelle Zijlstra 4586ed9adc Require black and isort for contributions (#3329)
* Add explanation to CONTRIBUTNG.md
* Add sample pre-commit script
* Check for correctly formatted files in CI

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
2020-06-28 15:28:28 -07:00
Sebastian Rittau 0704214701 Add pytest_mock stubs (#4275) 2020-06-27 19:46:47 -07:00
Sebastian Rittau 564a8220f4 Add float.__ceil__ and __floor__ (#4274)
Closes: #3195
2020-06-26 22:26:39 -07:00
Sebastian Rittau ad7c1cd7eb Update pytype (#4280) 2020-06-27 00:13:12 +02:00
Sebastian Rittau b05adddf5a pytype tests: Specify files or dirs to check (#4279)
This adds the ability to check single files or directories with
tests/pytype_test.py by specifying the paths to check on the
command line.
2020-06-26 20:45:38 +02:00
Sebastian Rittau a615a17976 Update black and work around an isort bug (#4242) 2020-06-19 08:32:05 -07:00
Sebastian Rittau 32c638cc88 Run the unused stubtest check only on python/typeshed (#4240)
Without this check, it is run on daily on every personal fork.
2020-06-18 10:47:05 -07:00
Sebastian Rittau 68a7b9b178 Collate all stubtest runs into a single output (#4231) 2020-06-17 11:48:44 -07:00
Sebastian Rittau 51cf2f51b8 Add IO protocols to _typeshed (#4230) 2020-06-14 20:44:48 +02:00
Sebastian Rittau ef74bee249 Protocol naming guidelines (#4229)
Closes: #4174
2020-06-14 17:00:19 +02:00
Sebastian Rittau 89d3a55f1a Preparations for the Big Reformat (#4228)
A few comments between imports were removed or moved to the top of the
import block, due to behavioral differences between black and isort. See
psf/black#251 for details.

In two instances @overloads at the top of the file needed to be moved
due to psf/black#1490.
2020-06-14 07:58:26 -07:00
Sebastian Rittau 53431cab1d Remove unused stubtest entries (#4225)
Rename job
2020-06-12 06:57:23 -07:00
Sebastian Rittau cf3b74a0bf Move stubtest CI to GitHub Actions (#4223)
This ensures that the Python version used matches the one used in the
scheduled extraneous stubtest whitelist check.

See also PR #4206.
2020-06-11 12:39:06 -07:00
Sebastian Rittau afe1e543b3 Make multiprocessing.Namespace accept any attribute (#4204)
Update multiprocessing.dummy.Namespace as well

Closes: #4186
2020-06-09 12:34:36 -07:00
Sebastian Rittau 206bff44ed Remove BinaryIO.write() (#4203)
write() is inherited from IO[bytes], where it's defined as
`def write(self, s: AnyStr) -> int: ...`. If AnyStr is bytes,
this should accept bytes, bytearray, and memoryview, so the
overload is unnecessary.

Closes: #4201
2020-06-08 13:40:41 -07:00
Sebastian Rittau 3d84c52a4c Do not stop other checks if one check fails (#4205) 2020-06-08 07:25:52 -07:00
Sebastian Rittau 1f82564ee2 Move wsgiref.types to _typeshed.wsgi (#4175)
Re-export the types from wsgiref.types for now to avoid breaking
existing code. wsgiref.types should be removed eventually.

Also, reduce the boilerplate description in _typeshed/wsgi.pyi as it
mirrors the description in _typeshed/__init__.pyi.
2020-06-04 15:38:45 -07:00
Sebastian Rittau eea9be6e73 Add a _typeshed.pyi file and a PathLike alias (#4161) 2020-06-04 14:06:43 +02:00
Sebastian Rittau d76ad4710e Find unused stubtest whitelist entries (#4157)
* Find unused stubtest whitelist entries

This is currently a GitHub workflow that runs daily and lists all unused
whitelist entries found by running stubtest against current Python
versions on Linux and Windows. The workflow run will succeed if there
are no such entries, and fail otherwise.

In a second step, this should collate the output of the various runs and
create a PR to remove the entries. In that case, the workflow should
probably only run weekly or even monthly to keep the noise down.

Cf. #3728
2020-06-03 14:37:38 +02:00
Sebastian Rittau a913af9523 flake8: Enable F811 (#4158) 2020-06-02 14:08:54 -07:00
Sebastian Rittau b2b397c5ce Add @CraftSpider and @hauntsaninja as maintainers (#4138) 2020-05-28 16:34:45 -07:00
Sebastian Rittau adafaf1964 Add review guidlines (#4132)
Closes: #3448
2020-05-28 15:18:05 +02:00
Sebastian Rittau 694fa80596 Add dateparser module (#4106)
Based on PR 3704 by @xcthulhu (Matthew Doty)
2020-05-27 18:53:16 -07:00
Sebastian Rittau be016c6793 Add retry_after to TooManyRequests and ServiceUnavailable (#4059)
Added in werkzeug 1.0.0

While the implementation accepts any value for retry_after, the docstring
allows only datetime and int. Using any other value could lead to an
invalid HTTP response.
2020-05-23 13:39:48 -07:00
Sebastian Rittau 92f52a2615 flake8 updates and cleanups (#3940)
* flake8 updates and cleanups

* Update to flake8 3.7.9.
* Update to flake8-bugbear 20.1.4.
* Only ignore errors in stub files.
* Remove obsolete error counts.
* Sort error codes alphabetically.
* Don't ignore the following errors (unneeded):
    * E704 Multiple statements on one line (def)
    * W504 Line break occurred after a binary operator
    * B303 __metaclass__ used

* Remove obsolete comment

* Ignore F822 undefined name in __all__
2020-04-23 19:38:47 -07:00
Sebastian Rittau 733c558d60 Add msilib and _msi to stubtest whitelist (#3939)
* Add msilib and _msi to stubtest whitelist

* Group Windows-only modules

* Move win modules to bottom

Make win modules optional
2020-04-23 19:09:52 -07:00
Sebastian Rittau 68190cefde Fix stubs for pymysql (#3781) 2020-03-05 09:21:52 +01:00
Sebastian Rittau ca9505c8f4 Improve imaplib return types (#3670)
* Improve imaplib return types

Mark CommandResults as obsolete.

Also fix types of tagged_commands and untagged_responses.

Based on a discussion in #3655.

* Fix type of tagged_commands

* Fix IMAP4.tagged_commands type

* Mark CommandResults as private

* Fix
2020-02-22 09:58:14 -08:00
Sebastian Rittau c710696aed Remove obsolete stubtest whitelist entries (#3773) 2020-02-22 18:05:12 +01:00
Sebastian Rittau 0e3286bc43 Remove consent requirement for third-party stubs (#3643)
This was discussed a while ago on typing-sig. Consequently the
requirement of asking third-party maintainers for permission was
removed from PEP 484.
2020-01-23 15:01:30 +01:00
Sebastian Rittau fdeae5d00e Enable --disallow-subclassing-any (#3591)
Closes: #1446
2020-01-08 11:51:44 -08:00
Sebastian Rittau 885c2fd65e Fix example code (#3592) 2020-01-08 09:52:23 -08:00
Sebastian Rittau 595d02363a Change return type of Message.get_payload() to Any (#3504)
If, for example, is_multipart() is called before calling get_payload(),
it is guaranteed that a List[Message] is returned.
2019-11-26 08:03:15 -08:00